Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the focus in the forms. #542

Closed
iGormilhit opened this issue Oct 1, 2019 · 1 comment
Closed

Set the focus in the forms. #542

iGormilhit opened this issue Oct 1, 2019 · 1 comment
Assignees
@benerken @lauren-d
Labels
enhancement Improvement of an existing feature f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface

Comments

@iGormilhit
Copy link

Describe the issue
As a user opens a form, ie the editor, the focus is not set.

To Reproduce
Steps to reproduce the behavior:

  1. Log in as a librarian.
  2. Try to create a new resource, for example a new circulation policy.
  3. Assert that you need multiple tab key hits, or to use the mouse, to type something into the first input of the form.

Expected behavior
Focus should be set where it's the most probable that a user wants to start to type.
@iGormilhit iGormilhit added enhancement Improvement of an existing feature f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface labels Oct 1, 2019
benerken added a commit to benerken/rero-ils that referenced this issue Nov 20, 2019
@benerken @lauren-d
editor: set the focus in the forms
b9da525 
* set the focus in the forms
* Closes rero#542

Co-Authored-by: Benoit Erken <[email protected]>
                Laurent Dubois <[email protected]>
lauren-d added a commit to benerken/rero-ils that referenced this issue Nov 20, 2019
@benerken @lauren-d
editor: set the focus in the forms
26caadb 
* add angular directive to set autofocus.
* update remote-input component to add autofocus binding.
* set the focus in the forms.
* update json schema forms to set default focus.
* Closes rero#542.

Co-Authored-by: Benoit Erken <[email protected]>
Co-Authored-by: Lauren-D <[email protected]>
@lauren-d lauren-d self-assigned this Nov 20, 2019
@lauren-d lauren-d mentioned this issue Nov 20, 2019
Closed
6 tasks
lauren-d added a commit to benerken/rero-ils that referenced this issue Nov 20, 2019
@benerken @lauren-d
editor: set the focus in the forms
6567ae6 
* add angular directive.
* update remote-input component to add autofocus binding.
* set the focus in the forms.
* update json schema forms to set default focus.
* Closes rero#542.

Co-Authored-by: Benoit Erken <[email protected]>
Co-Authored-by: Lauren-D <[email protected]>
lauren-d added a commit to benerken/rero-ils that referenced this issue Nov 20, 2019
@benerken @lauren-d
editor: set the focus in the forms
c391030 
* add angular directive.
* update remote-input component to add autofocus binding.
* set the focus in the forms.
* update json schema forms to set default focus.
* Closes rero#542.

Co-Authored-by: Benoit Erken <[email protected]>
Co-Authored-by: Lauren-D <[email protected]>
lauren-d added a commit to benerken/rero-ils that referenced this issue Nov 20, 2019
@benerken @lauren-d
editor: set the focus in the forms
be91379 
* add angular directive.
* update remote-input component to add autofocus binding.
* set the focus in the forms.
* update json schema forms to set default focus.
* Closes rero#542.

Co-Authored-by: Benoit Erken <[email protected]>
Co-Authored-by: Lauren-D <[email protected]>
lauren-d added a commit to benerken/rero-ils that referenced this issue Nov 21, 2019
@benerken @lauren-d
editor: set the focus in the forms
9371a57 
* add angular directive.
* update remote-input component to add autofocus binding.
* set the focus in the forms.
* update json schema forms to set default focus.
* Closes rero#542.

Co-Authored-by: Benoit Erken <[email protected]>
Co-Authored-by: Lauren-D <[email protected]>
lauren-d added a commit to benerken/rero-ils that referenced this issue Nov 22, 2019
@benerken @lauren-d
editor: set the focus in the forms
aab3b52 
* add angular directive.
* update remote-input component to add autofocus binding.
* set the focus in the forms.
* update json schema forms to set default focus.
* Closes rero#542.

Co-Authored-by: Benoit Erken <[email protected]>
Co-Authored-by: Lauren-D <[email protected]>
lauren-d added a commit to benerken/rero-ils that referenced this issue Nov 26, 2019
@benerken @lauren-d
editor: set the focus in the forms
b793068 
* Adds angular directive.
* Updates remote-input component to add autofocus binding.
* Sets the focus in the forms.
* Updates form option to set default focus.
* Closes rero#542.

Co-Authored-by: Benoit Erken <[email protected]>
Co-Authored-by: Lauren-D <[email protected]>
lauren-d added a commit to benerken/rero-ils that referenced this issue Nov 26, 2019
@benerken @lauren-d
editor: set the focus in the forms
723145f 
* Adds angular directive.
* Updates remote-input component to add autofocus binding.
* Sets the focus in the forms.
* Updates form options to set default focus.
* Closes rero#542.

Co-Authored-by: Benoit Erken <[email protected]>
Co-Authored-by: Lauren-D <[email protected]>
@iGormilhit
Copy link
Author

This issue is resolved, I think somewhere after the integration of ngx-formly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benerken benerken

@lauren-d lauren-d

Labels
enhancement Improvement of an existing feature f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iGormilhit @benerken @lauren-d