Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operation logs: improve dump_operation_logs CLI #2154

Merged
merged 1 commit into from
Jul 19, 2021
Merged

operation logs: improve dump_operation_logs CLI #2154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rero_ils/modules/operation_logs/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def dump_operation_logs(outfile_name, year):

index_count = 0
outfile = JsonWriter(outfile_name)
with click.progressbar(search.scan()) as bar:
with click.progressbar(search.scan(), length=search.count()) as bar:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the commit message be more precise? Add the search count to the progress bar or something?

for oplg in bar:
outfile.write(str(oplg.to_dict()))
index_count += 1
Expand Down