operation logs: improve dump_operation_logs CLI
#2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
f: activity-logs
Garfield-fr
approved these changes
Jul 13, 2021
iGormilhit
changed the title
dump_operation_logs CLI
iGormilhit
reviewed
Jul 19, 2021
| @@ -87,7 +87,7 @@ def dump_operation_logs(outfile_name, year): | |||
|
|
|||
| index_count = 0 | |||
| outfile = JsonWriter(outfile_name) | |||
| with click.progressbar(search.scan()) as bar: | |||
| with click.progressbar(search.scan(), length=search.count()) as bar: | |||
There was a problem hiding this comment.
Could the commit message be more precise? Add the search count to the progress bar or something?
jma
approved these changes
Jul 19, 2021
jma
approved these changes
Jul 19, 2021
iGormilhit
suggested changes
Jul 19, 2021
* Adds length to progress bar for display of remaining time. Co-Authored-by: Peter Weber <[email protected]>
rerowep
force-pushed
the
wep-operationlogs-cli
branch
from
3464d60 to
35a79bc
Compare
iGormilhit
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Peter Weber [email protected]
Why are you opening this PR?
Dependencies
My PR depends on the following
rero-ils-ui's PR(s):How to test?
Code review check list