Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

holdings: make vendor field optional #1442

Merged
merged 1 commit into from
Nov 16, 2020
Merged

holdings: make vendor field optional #1442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 25 additions & 41 deletions rero_ils/modules/holdings/jsonschemas/holdings/holding-v0.0.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,10 @@
"title": "Issue display template",
"description": "This template define how a prediction is displayed. i.e. year 2020; vol.1, iss. 4. It should contains the variable field between {{}} with the corresponding pattern and level name.",
"type": "string",
"default": "Vol. {{numbering.volume}}({{chronology.year}}), no {{numbering.number}} {{chronology.season}}",
"minLength": 3,
"pattern": ".*?\\{\\{.*?\\}\\}.*?",
"form": {
"placeholder": "Vol. {{numbering.vol}}, {{chronology.year}}",
"placeholder": "Example: Vol. {{numbering.volume}}, {{expected_date.year}}",
"validation": {
"messages": {
"patternMessage": "Should contains at least one variable between {{ }}."
Expand Down Expand Up @@ -278,38 +277,6 @@
"values": {
"title": "Prediction patterns",
"type": "array",
"default": [
{
"name": "numbering",
"levels": [
{
"number_name": "volume"
},
{
"number_name": "number",
"completion_value": 4
}
]
},
{
"name": "chronology",
"levels": [
{
"number_name": "year",
"next_value": 1990
},
{
"list_name": "season",
"mapping_values": [
"printemps",
"\u00e9t\u00e9",
"automne",
"hiver"
]
}
]
}
],
"minItems": 1,
"items": {
"title": "Prediction pattern",
Expand All @@ -328,7 +295,10 @@
"title": "Name",
"type": "string",
"description": "It should be used in the display template. i.e. chronology, enumeration.",
"minLength": 1
"minLength": 1,
"form": {
"placeholder": "Example: numbering"
}
},
"levels": {
"title": "Chronology levels",
Expand All @@ -355,25 +325,37 @@
"title": "Name",
"type": "string",
"description": "It should be used in the display template. i.e. year, month, volume, issue, etc.",
"minLength": 1
"minLength": 1,
"form": {
"placeholder": "Example: volume"
}
},
"starting_value": {
"title": "Starting value",
"description": "First value of the sequence.",
"type": "integer",
"minimum": 1
"minimum": 1,
"form": {
"placeholder": "Example: 1"
}
},
"completion_value": {
"title": "Completion of the values",
"description": "Last value of the sequence. If it is not defined the sequence will continue until the infinity.",
"type": "integer",
"minimum": 1
"minimum": 1,
"form": {
"placeholder": "Example: 12"
}
},
"next_value": {
"title": "Next predicted value",
"description": "Can be used to correct the next current prediction.",
"type": "integer",
"minimum": 1
"minimum": 1,
"form": {
"placeholder": "Example: 3"
}
}
}
},
Expand Down Expand Up @@ -458,10 +440,12 @@
],
"properties": {
"$ref": {
"title": "Vendor URI",
"type": "string",
"pattern": "^https://ils.rero.ch/api/vendors/.*?$",
"form": {
"expressionProperties": {
"templateOptions.required": "false"
},
"remoteOptions": {
"type": "vendors"
}
Expand Down Expand Up @@ -597,4 +581,4 @@
}
}
}
}
}