holdings: make vendor field optional #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
approved these changes
Nov 16, 2020
Fixes issues when the vendor field in the holdings record is mandatory (it shouldn't). Removes the old patterns default values from the holdings editor. Adds placeholders for the patterns fields of the holdings record. Co-Authored-by: Johnny Mariéthoz <[email protected]> Co-Authored-by: Nicolas Prongué <[email protected]> Co-Authored-by: Aly Badr <[email protected]>
BadrAly
force-pushed
the
baa-fix-holdings-vendor
branch
from
86fa7c4 to
ecb1839
Compare
BadrAly
changed the title
iGormilhit
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues when the vendor field in the
holdings record is mandatory (it shouldn't).
Removes the old patterns default values from
the holdings editor.
Adds placeholders for the patterns fields of the
holdings record.
Co-Authored-by: Johnny Mariéthoz [email protected]
Co-Authored-by: Nicolas Prongué [email protected]
Co-Authored-by: Aly Badr [email protected]
Why are you opening this PR?
Dependencies
My PR depends on the following
rero-ils-ui's PR(s):How to test?
Code review check list