-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional border is displayed for object types #248
Labels
f: editor
Concerns editor based on JSON schema AND custom editor
Comments
jma
added a commit
to jma/ng-core
that referenced
this issue
Jan 25, 2021
* Fixes tester document search routing. * Removes useless log messages. * Fixes import paths. * Replaces the css classes such as `editor-title` by a `card` wrapper. * Moves some common code lines in the editor service. * Moves the field label html code into a specific component. * Adds new `containerCSSClass`, `itemCSSClass` and `cssClass` to allow field grid positions. * Renders the hide/show/clone button in the children field instead of the parent (array, object) component. * Closes rero#328. * Closes rero#327. * Closes rero#325. * Closes rero#248. * Closes rero#242. Co-Authored-by: Johnny Mariéthoz <[email protected]>
jma
added a commit
to jma/ng-core
that referenced
this issue
Jan 27, 2021
* Fixes tester document search routing. * Removes useless log messages. * Fixes import paths. * Replaces the css classes such as `editor-title` by a `card` wrapper. * Moves some common code lines in the editor service. * Moves the field label html code into a specific component. * Adds new `containerCSSClass`, `itemCSSClass` and `cssClass` to allow field grid positions. * Renders the hide/show/clone button in the children field instead of the parent (array, object) component. * Adds external link support for remote typeahead editor component. * Closes rero#328. * Closes rero#327. * Closes rero#325. * Closes rero#248. * Closes rero#242. * Closes rero/rero-ils#1604. * Closes rero/rero-ils#1601. Co-Authored-by: Johnny Mariéthoz <[email protected]>
jma
added a commit
to jma/ng-core
that referenced
this issue
Jan 27, 2021
* Fixes tester document search routing. * Removes useless log messages. * Fixes import paths. * Replaces the css classes such as `editor-title` by a `card` wrapper. * Moves some common code lines in the editor service. * Moves the field label html code into a specific component. * Adds new `containerCSSClass`, `itemCSSClass` and `cssClass` to allow field grid positions. * Renders the hide/show/clone button in the children field instead of the parent (array, object) component. * Adds external link support for remote typeahead editor component. * Closes rero#328. * Closes rero#327. * Closes rero#325. * Closes rero#248. * Closes rero#242. * Closes rero/rero-ils#1604. * Closes rero/rero-ils#1601. Co-Authored-by: Johnny Mariéthoz <[email protected]>
jma
added a commit
to jma/ng-core
that referenced
this issue
Jan 27, 2021
* Fixes tester document search routing. * Removes useless log messages. * Fixes import paths. * Replaces the css classes such as `editor-title` by a `card` wrapper. * Moves some common code lines in the editor service. * Moves the field label html code into a specific component. * Adds new `containerCSSClass`, `itemCSSClass` and `cssClass` to allow field grid positions. * Renders the hide/show/clone button in the children field instead of the parent (array, object) component. * Adds external link support for remote typeahead editor component. * Closes rero#328. * Closes rero#327. * Closes rero#325. * Closes rero#248. * Closes rero#242. * Closes rero/rero-ils#1604. * Closes rero/rero-ils#1601. Co-Authored-by: Johnny Mariéthoz <[email protected]>
jma
added a commit
to jma/ng-core
that referenced
this issue
Jan 27, 2021
* Fixes tester document search routing. * Removes useless log messages. * Fixes import paths. * Replaces the css classes such as `editor-title` by a `card` wrapper. * Moves some common code lines in the editor service. * Moves the field label html code into a specific component. * Adds new `containerCSSClass`, `itemCSSClass` and `cssClass` to allow field grid positions. * Renders the hide/show/clone button in the children field instead of the parent (array, object) component. * Adds external link support for remote typeahead editor component. * Closes rero#328. * Closes rero#327. * Closes rero#325. * Closes rero#248. * Closes rero#242. * Closes rero/rero-ils#1604. * Closes rero/rero-ils#1601. Co-Authored-by: Johnny Mariéthoz <[email protected]>
jma
added a commit
to jma/ng-core
that referenced
this issue
Jan 28, 2021
* Fixes tester document search routing. * Removes useless log messages. * Fixes import paths. * Replaces the css classes such as `editor-title` by a `card` wrapper. * Moves some common code lines in the editor service. * Moves the field label html code into a specific component. * Adds new `containerCSSClass`, `itemCSSClass` and `cssClass` to allow field grid positions. * Renders the hide/show/clone button in the children field instead of the parent (array, object) component. * Adds external link support for remote typeahead editor component. * Closes rero#328. * Closes rero#327. * Closes rero#325. * Closes rero#248. * Closes rero#242. * Closes rero/rero-ils#1604. * Closes rero/rero-ils#1601. Co-Authored-by: Johnny Mariéthoz <[email protected]>
jma
added a commit
that referenced
this issue
Feb 10, 2021
* Fixes tester document search routing. * Removes useless log messages. * Fixes import paths. * Replaces the css classes such as `editor-title` by a `card` wrapper. * Moves some common code lines in the editor service. * Moves the field label html code into a specific component. * Adds new `containerCSSClass`, `itemCSSClass` and `cssClass` to allow field grid positions. * Renders the hide/show/clone button in the children field instead of the parent (array, object) component. * Adds external link support for remote typeahead editor component. * Closes #328. * Closes #327. * Closes #325. * Closes #248. * Closes #242. * Closes rero/rero-ils#1604. * Closes rero/rero-ils#1601. Co-Authored-by: Johnny Mariéthoz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the issue
Following this property example:
The
editor-title
CSS class is added twice in the HTML, causing an extra border in the property.To Reproduce
Edition
field.Edition
properties.Expected behavior
The additional border must not be displayed. In other word, the
editor-title
class must be added only one time.Screenshots
![Capture d’écran 2020-08-31 à 13 29 41](https://user-images.githubusercontent.com/6112685/91715508-10534f00-eb8e-11ea-80b2-bd2f4af6d9b0.png)
The text was updated successfully, but these errors were encountered: