Skip to content

Commit

Permalink
editor: fix issues
Browse files Browse the repository at this point in the history
* Fixes tester document search routing.
* Removes useless log messages.
* Fixes import paths.
* Replaces the css classes such as `editor-title` by a `card` wrapper.
* Moves some common code lines in the editor service.
* Moves the field label html code into a specific component.
* Adds new `containerCSSClass`, `itemCSSClass` and `cssClass` to allow
  field grid positions.
* Renders the hide/show/clone button in the children field instead of
  the parent (array, object) component.
* Adds external link support for remote typeahead editor component.
* Closes rero#328.
* Closes rero#327.
* Closes rero#325.
* Closes rero#248.
* Closes rero#242.
* Closes rero/rero-ils#1604.
* Closes rero/rero-ils#1601.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
  • Loading branch information
jma committed Jan 27, 2021
1 parent d0bbaad commit 3c53cb3
Show file tree
Hide file tree
Showing 34 changed files with 975 additions and 733 deletions.
12 changes: 6 additions & 6 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
"@angular/router": "^11.0.9",
"@biesbjerg/ngx-translate-extract": "^7.0.3",
"@biesbjerg/ngx-translate-extract-marker": "^1.0.0",
"@ngx-formly/bootstrap": "^5.10.11",
"@ngx-formly/core": "^5.10.11",
"@ngx-formly/bootstrap": "^5.10.12",
"@ngx-formly/core": "^5.10.12",
"@ngx-translate/core": "^13.0.0",
"@ngx-translate/http-loader": "^6.0.0",
"bootstrap": "^4.5.3",
Expand Down
13 changes: 6 additions & 7 deletions projects/ng-core-tester/src/app/app-routing.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,21 +104,17 @@ const canUpdateFilesMetadata = (): Observable<ActionStatus> => {
// Permissions override simple canRead, canUpdate and canDelete if defined
const permissions = (record: any) => {
const perms = record.metadata.permissions;
perms.read = true;
perms.update = true;
perms.delete = false;

return of({
canRead: {
can: perms.read,
can: perms ? perms.read : true,
message: '',
},
canUpdate: {
can: perms.update,
can: perms ? perms.update : false,
message: '',
},
canDelete: {
can: perms.delete,
can: perms ? perms.delete : false,
message: 'This record cannot be deleted.',
},
});
Expand Down Expand Up @@ -226,6 +222,9 @@ const routes: Routes = [
{
key: 'documents',
label: 'Documents',
editorSettings: {
longMode: true
},
component: DocumentComponent
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,13 @@ export class EditorComponent {
}
};

// TODO:
// hide as expression

// JSONSchema
schema = {};

// form intial values
// form initial values
model = {};

/** Constructor */
Expand Down
Loading

0 comments on commit 3c53cb3

Please sign in to comment.