Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Specflow remains in links and comments #382

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Remove Specflow remains in links and comments #382

merged 2 commits into from
Jan 8, 2025

Conversation

obligaron
Copy link
Contributor

🤔 What's changed?

Searched for "specflow" and replaced links/comments with Reqnroll alternatives.

⚡️ What's your motivation?

Specflow and the repro are gone, so probably all links are or will be gone soon.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

Github issue 1052 can be accessed via web archive: https://web.archive.org/web/20200926191603/https://github.com/SpecFlowOSS/SpecFlow/issues/1052

📋 Checklist:

Copy link
Contributor

@gasparnagy gasparnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, this is great. I had only a small fix requested.

@@ -61,7 +61,7 @@ private void WriteAppSettings(XmlWriter writer, Configuration configuration)

private void WriteReqnroll(XmlWriter writer, Configuration configuration)
{
writer.WriteStartElement("specFlow");
writer.WriteStartElement("reqnRoll");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be all lower: reqnroll

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed 🙂

Copy link
Contributor

@gasparnagy gasparnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@gasparnagy gasparnagy merged commit 743ab29 into main Jan 8, 2025
5 checks passed
@gasparnagy gasparnagy deleted the specflow branch January 8, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants