Skip to content

Commit

Permalink
Remove Specflow remains in links and comments (#382)
Browse files Browse the repository at this point in the history
* Remove Specflow remains

* lower case reqnroll for app config
  • Loading branch information
obligaron authored Jan 8, 2025
1 parent 233cc7a commit 743ab29
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ private static void RegisterProxyBindings(IObjectContainer objectContainer, ISer
// While they can (and should) use the method params for injection, we can support it.
// Note that in Feature mode, one can't inject "ScenarioContext", this can only be done from method params.

// Bases on this: https://docs.specflow.org/projects/specflow/en/latest/Extend/Available-Containers-%26-Registrations.html
// Bases on this: https://docs.reqnroll.net/latest/extend/available-containers.html#global-container
// Might need to add more...

services.AddSingleton<IObjectContainer>(objectContainer);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public enum ScopeLevelType
public class ScenarioDependenciesAttribute : Attribute
{
/// <summary>
/// Automatically register all SpecFlow bindings.
/// Automatically register all Reqnroll bindings.
/// </summary>
public bool AutoRegisterBindings { get; set; } = true;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ public void SetRow(TestClassGenerationContext generationContext, CodeMemberMetho

var tagsArray = tags.ToArray();

// addressing ReSharper bug: TestCase attribute with empty string[] param causes inconclusive result - https://github.com/SpecFlowOSS/SpecFlow/issues/116
// addressing ReSharper bug: TestCase attribute with empty string[] param causes inconclusive result - https://youtrack.jetbrains.com/issue/RSRP-279138
bool hasExampleTags = tagsArray.Any();
var exampleTagExpressionList = tagsArray.Select(t => (CodeExpression)new CodePrimitiveExpression(t));
var exampleTagsExpression = hasExampleTags
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@MSTest
Feature: GH1052

Wrong scenario context injected when running tests in parallel using NUnit (also specrun) - https://github.com/SpecFlowOSS/SpecFlow/issues/1052
Wrong scenario context injected when running tests in parallel using NUnit


Scenario: GH1052
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
@ignore
Feature: GH1052

Wrong scenario context injected when running tests in parallel using NUnit (also specrun) - https://github.com/reqnroll/Reqnroll/issues/1052
Wrong scenario context injected when running tests in parallel using NUnit


Scenario: GH1052
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ private void WriteAppSettings(XmlWriter writer, Configuration configuration)

private void WriteReqnroll(XmlWriter writer, Configuration configuration)
{
writer.WriteStartElement("specFlow");
writer.WriteStartElement("reqnroll");

if (configuration.BindingCulture != null)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,6 @@ private void EnsureProjectExists()
_project.AddNuGetPackage("System.Runtime.CompilerServices.Unsafe", "6.0.0", new NuGetPackageAssembly("System.Runtime.CompilerServices.Unsafe, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a", "netstandard2.0\\System.Runtime.CompilerServices.Unsafe.dll"));
}

// TODO: dei replace this hack with better logic when SpecFlow 3 can be strong name signed
_project.AddNuGetPackage("Reqnroll", _currentVersionDriver.ReqnrollNuGetVersion, new NuGetPackageAssembly("Reqnroll", "net462\\Reqnroll.dll"));

var generator = _bindingsGeneratorFactory.FromLanguage(_project.ProgrammingLanguage);
Expand Down

0 comments on commit 743ab29

Please sign in to comment.