Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2213] Fix hr element not appearing in report #2279

Merged
merged 4 commits into from
Feb 5, 2025
Merged

[#2213] Fix hr element not appearing in report #2279

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d781258
Set hr element style in style.scss
lyuanww Feb 2, 2025
34f4a58
Merge branch 'master' into 2213-fix-hr-element-not-appearing-in-report
CYX22222003 Feb 4, 2025
e7b3a75
Add comment
lyuanww Feb 5, 2025
e7daf1f
Merge branch 'master' into 2213-fix-hr-element-not-appearing-in-report
sopa301 Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions frontend/src/styles/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ a.broken-link {
text-decoration: none;
}

hr {
// This is needed because normalize.css sets the height to 0px.
height: 1px;
}

Copy link
Contributor

@CYX22222003 CYX22222003 Feb 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested on my local machine, and this change indeed makes the inserted horizontal line reappear at the generated report.

[v-cloak] {
display: none;
}
Expand Down