Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2213] Fix hr element not appearing in report #2279

Merged
merged 4 commits into from
Feb 5, 2025
Merged

[#2213] Fix hr element not appearing in report #2279

merged 4 commits into from
Feb 5, 2025

Conversation

lyuanww
Copy link
Contributor

@lyuanww lyuanww commented Feb 2, 2025

Fixes #2213

Proposed commit message

Fix the <hr> element not appearing in report.

The <hr> element in title.md and blurbs.md is not appearing in the
report because the normalise.css defaults the <hr> element style.

Let's override the <hr> element style in style.scss so that it will
appear in the report.

@lyuanww lyuanww changed the title [#2213]Fix hr element not appearing in report [#2213] Fix hr element not appearing in report Feb 3, 2025
@lyuanww lyuanww marked this pull request as ready for review February 3, 2025 05:16
@lyuanww lyuanww requested a review from a team February 3, 2025 05:16
CYX22222003
CYX22222003 approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@CYX22222003 CYX22222003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your PR

frontend/src/styles/style.scss
hr {
height: 1px;
}

Copy link
Contributor

@CYX22222003 CYX22222003 Feb 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested on my local machine, and this change indeed makes the inserted horizontal line reappear at the generated report.

@CYX22222003 CYX22222003 requested a review from a team February 4, 2025 00:40
sopa301
sopa301 approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@sopa301 sopa301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I think adding a comment to explain the change would help future developers.

@sopa301 sopa301 merged commit 45f1e4f into reposense:master Feb 5, 2025
11 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sopa301 sopa301 sopa301 approved these changes

@CYX22222003 CYX22222003 CYX22222003 approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The hr element in title.md and blurbs.md is not appearing in the generated report
3 participants
@lyuanww @sopa301 @CYX22222003