Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to be pretty conservative here and not modernise the code that doesn't need to be. This unfortunately still doesn't fix #59 :^( . When I run it with
env METAL_DEVICE_WRAPPER_TYPE=1
I do get a panic with:validateFunctionArguments:3727: failed assertion 'Fragment Function(main0): argument v_69[0] from buffer(0) with offset(0) and length(176) has space for 176 bytes, but argument has a length(224).'
I'll see if switching to naga fixes this, and if not, I'll have a go at a gfx backend.