feat!: remove skipInstalls config option

docs/usage/self-hosted-configuration.md

@@ -29,7 +29,7 @@ module.exports = {
 
 In the `renovate.json` file, define the commands and files to be included in the final commit.
 
-The command to install dependencies (`npm ci --ignore-scripts`) is needed because, by default, the installation of dependencies is skipped (see the `skipInstalls` global option).
+The command to install dependencies (`npm ci --ignore-scripts`) is needed because, by default, the installation of dependencies is skipped.
 
 ```json
 {
@@ -798,12 +798,6 @@ It could then be used in a repository config or preset like so:
 
 Secret names must start with an upper or lower case character and can have only characters, digits, or underscores.
 
-## skipInstalls
-
-By default, Renovate will use the most efficient approach to updating package files and lock files, which in most cases skips the need to perform a full module install by the bot.
-If this is set to false, then a full install of modules will be done.
-This is currently applicable to `npm` and `lerna`/`npm` only, and only used in cases where bugs in `npm` result in incorrect lock files being updated.
-
 ## token
 
 ## unicodeEmoji

lib/config/options/index.ts

@@ -729,14 +729,6 @@ const options: RenovateOptions[] = [
     description: 'Set to `false` to disable lock file updating.',
     type: 'boolean',
   },
-  {
-    name: 'skipInstalls',
-    description:
-      'Skip installing modules/dependencies if lock file updating is possible without a full install.',
-    type: 'boolean',
-    default: null,
-    globalOnly: true,
-  },
   {
     name: 'autodiscover',
     description: 'Autodiscover all repositories.',

lib/config/types.ts

@@ -260,7 +260,6 @@ export interface RenovateConfig
   secrets?: Record<string, string>;
 
   constraints?: Record<string, string>;
-  skipInstalls?: boolean | null;
 
   constraintsFiltering?: ConstraintsFilter;
 

lib/modules/manager/npm/extract/index.spec.ts

@@ -9,7 +9,7 @@ const realFs = jest.requireActual<typeof import('../../../../util/fs')>(
 );
 
 const defaultExtractConfig = {
-  skipInstalls: null,
+  skipInstalls: true,
 } satisfies ExtractConfig;
 
 const input01Content = Fixtures.get('inputs/01.json', '..');

lib/modules/manager/npm/extract/index.ts

@@ -473,19 +473,15 @@ export async function extractPackageFile(
       return null;
     }
   }
-  let skipInstalls = config.skipInstalls;
-  if (skipInstalls === null) {
-    if ((hasFancyRefs && lockFiles.npmLock) || yarnZeroInstall) {
-      // https://github.com/npm/cli/issues/1432
-      // Explanation:
-      //  - npm install --package-lock-only is buggy for transitive deps in file: and npm: references
-      //  - So we set skipInstalls to false if file: or npm: refs are found *and* the user hasn't explicitly set the value already
-      //  - Also, do not skip install if Yarn zero-install is used
-      logger.debug('Automatically setting skipInstalls to false');
-      skipInstalls = false;
-    } else {
-      skipInstalls = true;
-    }
+  let skipInstalls = true; // skip installing modules by default
+  if ((hasFancyRefs && lockFiles.npmLock) || yarnZeroInstall) {
+    // https://github.com/npm/cli/issues/1432
+    // Explanation:
+    //  - npm install --package-lock-only is buggy for transitive deps in file: and npm: references
+    //  - So we set skipInstalls to false if file: or npm: refs are found *and* the user hasn't explicitly set the value already
+    //  - Also, do not skip install if Yarn zero-install is used
+    logger.debug('Automatically setting skipInstalls to false');
+    skipInstalls = false;
   }
 
   return {

lib/modules/manager/types.ts

@@ -20,7 +20,7 @@ export interface ExtractConfig extends CustomExtractConfig {
   registryAliases?: Record<string, string>;
   npmrc?: string;
   npmrcMerge?: boolean;
-  skipInstalls?: boolean | null;
+  skipInstalls?: boolean;
 }
 
 export interface CustomExtractConfig extends RegexManagerTemplates {
@@ -65,7 +65,7 @@ export interface PackageFileContent<T = Record<string, any>>
   lockFiles?: string[];
   npmrc?: string;
   packageFileVersion?: string;
-  skipInstalls?: boolean | null;
+  skipInstalls?: boolean;
   matchStrings?: string[];
   matchStringsStrategy?: MatchStringsStrategy;
 }
@@ -275,7 +275,7 @@ export interface PostUpdateConfig<T = Record<string, any>>
     ManagerData<T> {
   updatedPackageFiles?: FileChange[];
   postUpdateOptions?: string[];
-  skipInstalls?: boolean | null;
+  skipInstalls?: boolean;
   ignoreScripts?: boolean;
 
   packageFile?: string;

lib/workers/repository/extract/extract-fingerprint-config.spec.ts

@@ -47,7 +47,6 @@ describe('workers/repository/extract/extract-fingerprint-config', () => {
       registryAliases: {
         notStable: 'http://some.link.2',
       },
-      skipInstalls: null,
     });
     expect(
       fingerprintConfig.managers.find((manager) => manager.manager === 'regex')
@@ -66,7 +65,6 @@ describe('workers/repository/extract/extract-fingerprint-config', () => {
       registryAliases: {
         stable: 'http://some.link',
       },
-      skipInstalls: null,
     });
   });
 
@@ -90,7 +88,6 @@ describe('workers/repository/extract/extract-fingerprint-config', () => {
       npmrc: 'some-string',
       npmrcMerge: true,
       registryAliases: {},
-      skipInstalls: null,
     });
     expect(
       fingerprintConfig.managers.find(
@@ -109,7 +106,6 @@ describe('workers/repository/extract/extract-fingerprint-config', () => {
       npmrc: 'some-string',
       npmrcMerge: true,
       registryAliases: {},
-      skipInstalls: null,
     });
     expect(
       fingerprintConfig.managers.find((manager) => manager.manager === 'regex')