feat!: remove skipInstalls config option
#22648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
gitAuthor discover for GitLab now prefers the field `commit_email` over `email`. BREAKING CHANGE: GitLab gitAuthor will change from the account's "email" to "commit_email" if they are different.
…ebot#21282) Set `{ dot: true }` for minimatch. BREAKING CHANGE: dot files will now be included by default for all minimatch results
…ot#22406) Co-authored-by: HonkingGoose <[email protected]>
RahulGautamSingh
changed the title
skipInstalls config optionskipInstalls config option
|
I don't understand the coverage fail. the line is ignored still the codecov asks for coverage. |
6 tasks
viceice
previously approved these changes
Jun 12, 2023
No
We don't have a test case, that's why we use |
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
gitAuthor discover for GitLab now prefers the field `commit_email` over `email`. BREAKING CHANGE: GitLab gitAuthor will change from the account's "email" to "commit_email" if they are different.
…ebot#21282) Set `{ dot: true }` for minimatch. BREAKING CHANGE: dot files will now be included by default for all minimatch results
…ot#22406) Co-authored-by: HonkingGoose <[email protected]>
|
@RahulGautamSingh looks like a bad merge - 27 files changed |
rarkins
approved these changes
Jun 12, 2023
rarkins
pushed a commit
that referenced
this pull request
Jun 15, 2023
rarkins
pushed a commit
that referenced
this pull request
Jun 18, 2023
rarkins
pushed a commit
that referenced
this pull request
Jun 18, 2023
rarkins
pushed a commit
that referenced
this pull request
Jun 18, 2023
rarkins
pushed a commit
that referenced
this pull request
Jun 27, 2023
rarkins
pushed a commit
that referenced
this pull request
Jun 27, 2023
rarkins
pushed a commit
that referenced
this pull request
Jul 1, 2023
rarkins
pushed a commit
that referenced
this pull request
Jul 4, 2023
rarkins
pushed a commit
that referenced
this pull request
Jul 4, 2023
rarkins
pushed a commit
that referenced
this pull request
Jul 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
skipInstallsconfig optin from self-hosted configurationContext
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: