Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add node v16 tests #12244

Merged
merged 8 commits into from
Jan 16, 2022
Merged

ci: add node v16 tests #12244

merged 8 commits into from
Jan 16, 2022

Conversation

viceice
Copy link
Member

@viceice viceice commented Oct 21, 2021 •
edited
Loading

Changes:

add node v16 to ubuntu tests

Context:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested a review from rarkins October 21, 2021 07:46
@viceice viceice marked this pull request as ready for review October 21, 2021 08:24
@viceice viceice marked this pull request as draft October 21, 2021 08:25
@viceice
Copy link
Member Author

viceice commented Oct 21, 2021

seems to have test issues on node v16 😕

@viceice
Copy link
Member Author

viceice commented Oct 21, 2021

OOM again 😢
image

@viceice
Copy link
Member Author

viceice commented Oct 27, 2021 •
edited
Loading

@rarkins
Copy link
Collaborator

rarkins commented Oct 27, 2021

Hopefully we don't need to support node 16 before we can test it.

@viceice
Copy link
Member Author

viceice commented Oct 27, 2021

i think renovate will basically work on node v16, but jest seems to have big issues with memory again 😕

@viceice
Copy link
Member Author

viceice commented Oct 27, 2021

@rarkins 🎉 It works now. I've simply excluded js files from ts-jest typescript config. Should i send a separate pr with the test changes? Those will also reduce heap usage alot

@viceice viceice mentioned this pull request Nov 3, 2021
Closed
@viceice viceice marked this pull request as ready for review November 3, 2021 17:52
@viceice viceice mentioned this pull request Nov 4, 2021
Closed
@rarkins
Copy link
Collaborator

rarkins commented Nov 4, 2021

@viceice let's do a separate PR with the refactoring and then isolate the Node 16 change

@rarkins rarkins marked this pull request as draft November 5, 2021 07:00
@viceice viceice mentioned this pull request Nov 5, 2021
Merged
6 tasks
@viceice viceice mentioned this pull request Nov 15, 2021
Merged
6 tasks
@viceice viceice added the ci:fulltest Run full test suite on all platforms label Jan 5, 2022
@viceice viceice marked this pull request as ready for review January 5, 2022 13:03
@viceice viceice enabled auto-merge (squash) January 16, 2022 10:49
@viceice viceice merged commit 0fdede3 into main Jan 16, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 31.28.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2022
@JamieMagee JamieMagee deleted the ci/test-node-v16 branch August 20, 2022 04:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@JamieMagee JamieMagee Awaiting requested review from JamieMagee

Assignees
No one assigned
Labels
ci:fulltest Run full test suite on all platforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viceice @rarkins @renovate-release