Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/validate node 16 for Renovate runtime #12177

Closed
rarkins opened this issue Oct 15, 2021 · 5 comments · Fixed by #18584
Closed

Test/validate node 16 for Renovate runtime #12177

rarkins opened this issue Oct 15, 2021 · 5 comments · Fixed by #18584
Assignees
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Oct 15, 2021

What would you like Renovate to be able to do?

Use node 16 as runtime, and upgrade to it for official Renovate images.

If you have any ideas on how this should be implemented, please tell us here.

It should be pretty stable by now, so perhaps we can return to having a matrix of node 14 + 16 for a while until we migrate to testing only 16?

Is this a feature you are interested in implementing yourself?

No

@rarkins rarkins added type:feature Feature (new functionality) status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage labels Oct 15, 2021
@viceice
Copy link
Member

viceice commented Oct 15, 2021

sounds good, node v16 should be next lts on 2022-10-18

https://nodejs.org/en/about/releases/

@HonkingGoose HonkingGoose added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others and removed priority-5-triage labels Oct 18, 2021
@viceice viceice mentioned this issue Oct 21, 2021
6 tasks
@viceice viceice self-assigned this Oct 21, 2021
@viceice viceice added status:in-progress Someone is working on implementation and removed status:requirements Full requirements are not yet known, so implementation should not be started labels Oct 21, 2021
@viceice
Copy link
Member

viceice commented Nov 10, 2021

npx will fail on npm v7

npx semantic-release --dry-run ${{env.DRY_RUN}}

Seen this on buildpack

image

@viceice
Copy link
Member

viceice commented Nov 10, 2021

@redeyes2015
Copy link

redeyes2015 commented May 13, 2022

I think this is related: mysticatea/npm-run-all#209

In short: due to how npx works since npm@7, npm-run-all does not work properly if invoked in npx.

The possible work-around for now seems to be:

  1. avoid npx , use node_modules/.bin/the-command directly
  2. use run-s --npm-path npm in every whererun-s/run-p/npm-run-all is used

@mcser
Copy link

mcser commented Sep 1, 2022

I am a little confused what the issue is here. I tried to reproduce this by forking the project and configuring a pipeline in my repository using node 16 to try and dry-run semantic-release, and on my end it appears to be working (but refuses to release a version of your image, of course).

Run npx semantic-release --dry-run false
[12:56:39 PM] [semantic-release] › ℹ  Running semantic-release version 19.0.5
[12:56:39 PM] [semantic-release] › ✔  Loaded plugin "verifyConditions" from "@semantic-release/github"
[12:56:39 PM] [semantic-release] › ✔  Loaded plugin "verifyConditions" from "@semantic-release/exec"
[12:56:39 PM] [semantic-release] › ✔  Loaded plugin "analyzeCommits" from "@semantic-release/commit-analyzer"
[12:56:39 PM] [semantic-release] › ✔  Loaded plugin "analyzeCommits" from "@semantic-release/exec"
[12:56:39 PM] [semantic-release] › ✔  Loaded plugin "verifyRelease" from "@semantic-release/exec"
[12:56:39 PM] [semantic-release] › ✔  Loaded plugin "generateNotes" from "@semantic-release/release-notes-generator"
[12:56:39 PM] [semantic-release] › ✔  Loaded plugin "generateNotes" from "@semantic-release/exec"
[12:56:39 PM] [semantic-release] › ✔  Loaded plugin "prepare" from "@semantic-release/exec"
[12:56:39 PM] [semantic-release] › ✔  Loaded plugin "publish" from "@semantic-release/github"
[12:56:39 PM] [semantic-release] › ✔  Loaded plugin "publish" from "@semantic-release/exec"
[12:56:39 PM] [semantic-release] › ✔  Loaded plugin "addChannel" from "@semantic-release/github"
[12:56:39 PM] [semantic-release] › ✔  Loaded plugin "addChannel" from "@semantic-release/exec"
[12:56:39 PM] [semantic-release] › ✔  Loaded plugin "success" from "@semantic-release/github"
[12:56:39 PM] [semantic-release] › ✔  Loaded plugin "success" from "@semantic-release/exec"
[12:56:39 PM] [semantic-release] › ✔  Loaded plugin "fail" from "@semantic-release/github"
[12:56:39 PM] [semantic-release] › ✔  Loaded plugin "fail" from "@semantic-release/exec"
[12:57:31 PM] [semantic-release] › ✔  Run automated release from branch main on repository https://github.com/renovatebot/renovate.git
[12:57:31 PM] [semantic-release] › ℹ  The local branch main is behind the remote one, therefore a new version won't be published.

EDIT: Woops I just realized that I had dry-run false, I'll try it again with the flag set to true.

EDIT 2: Same result with dry run set to true.

@viceice viceice closed this as completed Dec 30, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants