Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(remix-dev): log when using future flags that have been removed or stablized #6211

Closed
wants to merge 38 commits into from
Closed

chore(remix-dev): log when using future flags that have been removed or stablized #6211

wants to merge 38 commits into from

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Apr 27, 2023

given the following future config:

  future: {
    unstable_dev: true,
    v2_errorBoundary: true,
    v2_meta: true,
    v2_normalizeFormMethod: true,
    v2_routeConvention: true,
  },

image

Closes: #

  • Docs
  • Tests

Testing Strategy:

markdalgleish and others added 30 commits April 21, 2023 11:54
@markdalgleish
templates: add css-bundle boilerplate (#6110)
85c3cb6
@brophdawg11
Fix false-positive resource route identification if a route only expo… (
320c7ea 
#6125)
@jacob-ebey
feat: add @remix-run/node/install side-effect to allow --require (#…
e61cdc8 
…6132)
@remix-run-bot
chore: format
e696522
@pcattori
feat(dev): unstable dev server improvements (#6133)
e6067b7
@remix-run-bot
chore: format
6fd8ee4
@brophdawg11
Fix splat route index matching (#6130)
e48bdff
@pcattori
fix(dev): handle rebuilds that start before previous one finished (#6155
3709710 
)
@jacob-ebey
feat(remix-dev): add warning for v2 "cjs"->"esm" defaults (#6154)
8a74add
@remix-run-bot
chore: format
1501595
@pcattori
fix(dev): get dependencies bin path for any package manager (#6157)
12f224e
@pcattori
fix(dev): define process.env.REMIX_DEV_HTTP_PORT in server build (#…
341dd3a 
…6158)
@pcattori
fix(dev): export devReady from runtime packages (#6159)
76598cd
@jacob-ebey
feat: revalidate loaders only when a change to one is detected (#6135)
a03c8ae
@remix-run-bot
chore: format
6295eb6
@pcattori
fix(dev): handle new routes gracefully (#6165)
e4713ea
@mcansh
chore(remix-node): bump @remix-run/web-fetch to latest (#6120)
37d8b7d 
Signed-off-by: Logan McAnsh <[email protected]>
@mcansh
ci: disable tsc annotations for files changed (#6166)
08ab24e 
Signed-off-by: Logan McAnsh <[email protected]>
@pcattori
fix(dev): statically serve built assets from dev server (#6173)
7d73586
@pcattori
fix(dev): reliably detect path to bin for deps (#6175)
4ec885b
@pcattori
fix(dev): force NODE_ENV=development for dev server (#6176)
6e66529
@jacob-ebey
fix: short circuit links and meta for routes that are not rendered du…
2f008d0 
…e to errors (#6107)
@jacob-ebey
feat: express template outputs ESM for build (#6174)
754d885
@remix-run-bot
chore: format
01dff38
@pcattori
feat(dev): dev command defaults to remix-serve (#6177)
b523450
@remix-run-bot
chore: format
73b63c0
@jacob-ebey
chore(remix-node): add missing files to published package (#6179)
16891f2
@MichaelDeBoey @jacob-ebey
feat: support async getLoadContext in all adapters (#6170)
b2df1c7 
Co-authored-by: Jacob Ebey <[email protected]>
@fernandojbf @jacob-ebey @MichaelDeBoey
feat(remix-server-runtime): pass AppLoadContext to handleRequest (#…
98bdd4c 
…5836)

Co-authored-by: Jacob Ebey <[email protected]>
Co-authored-by: Michaël De Boey <[email protected]>
@jacob-ebey
fix(remix-dev): use correct require context in serverBareModulesPlugin (
140dd0e 
#6181)
@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 945661c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mcansh mcansh changed the base branch from dev to v2 April 27, 2023 13:34
ankit-gautam23
ankit-gautam23 approved these changes Apr 29, 2023
View reviewed changes
Copy link

@ankit-gautam23 ankit-gautam23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelDeBoey MichaelDeBoey force-pushed the v2 branch 2 times, most recently from f5ef1ac to 3d4c05e Compare May 16, 2023 19:56
@MichaelDeBoey
Copy link
Member

@mcansh I guess this PR is obsolete now?

CC/ @brophdawg11

@brophdawg11
Copy link
Contributor

Oh snap, I totally forgot about this. I still like this while remix.config.js is a JS file and not a TS file since there's no warning about flags that are now useless. I'm going to cherry-pick the relevant commits into a new PR against dev and confirm with the team.

@brophdawg11 brophdawg11 mentioned this pull request Aug 3, 2023
Merged
@brophdawg11
Copy link
Contributor

Closing in favor of #7048

@brophdawg11 brophdawg11 closed this Aug 3, 2023
@brophdawg11 brophdawg11 deleted the logan/v2-removed-future branch August 3, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

@ankit-gautam23 ankit-gautam23 ankit-gautam23 approved these changes

Assignees
No one assigned
Labels
CLA Signed package:dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mcansh @MichaelDeBoey @brophdawg11 @ankit-gautam23 @markdalgleish @jacob-ebey @remix-run-bot @pcattori @fernandojbf