Fix splat route index matching #6130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3070fdf The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 task
ryanflorence
approved these changes
Apr 21, 2023
brophdawg11
commented
Apr 21, 2023
| export default function Component() { | ||
| return <h1>Index</h1>; | ||
| } | ||
| `, |
There was a problem hiding this comment.
Needed an index route in this existing test. Putting path:"" on the root previously meant that / would match the root route without it having an index.jsx or $.jsx file, which seems like a related bug that's also fixed here
github-actions
bot
added
the
awaiting release
1 task
|
🤖 Hello there, We just published version Thanks! |
brophdawg11
added a commit
that referenced
this pull request
Apr 27, 2023
This reverts commit e48bdff.
brophdawg11
added a commit
that referenced
this pull request
Apr 27, 2023
This reverts commit e48bdff.
This was referenced Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root splat routes should match
/if an index route is not present. I.e.:Closes #5841