Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-node): fix NodeRequest's clone function #5566

Closed
wants to merge 2 commits into from

Conversation

tomer-yechiel
Copy link
Contributor

@tomer-yechiel tomer-yechiel commented Feb 25, 2023

Closes: #5520

  • Docs
  • Tests

Testing Strategy:

Add test case

@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2023

⚠️ No Changeset found

Latest commit: 400d557

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 25, 2023

Hi @tomer-yechiel,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 25, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@github-actions github-actions bot added the needs-response We need a response from the original author about this issue/PR label Apr 26, 2023
@remix-run remix-run deleted a comment from github-actions bot Apr 30, 2023
@machour machour removed the needs-response We need a response from the original author about this issue/PR label Apr 30, 2023
@MichaelDeBoey MichaelDeBoey changed the title Fix request clone fix(remix-node): fix NodeRequest's clone function May 2, 2023
@MichaelDeBoey MichaelDeBoey changed the base branch from main to dev May 2, 2023 13:45
@MichaelDeBoey MichaelDeBoey changed the base branch from dev to main May 2, 2023 13:45
@MichaelDeBoey
Copy link
Member

@tomer-yechiel Seems like something went wrong with rebasing.
Please rebase onto latest dev & set base branch of this PR to dev as well

@MichaelDeBoey MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label May 2, 2023
@tomer-yechiel tomer-yechiel changed the base branch from main to dev May 2, 2023 14:18
@tomer-yechiel
Copy link
Contributor Author

@tomer-yechiel Seems like something went wrong with rebasing. Please rebase onto latest dev & set base branch of this PR to dev as well

@MichaelDeBoey done

@tomer-yechiel tomer-yechiel force-pushed the fix-request-clone branch 2 times, most recently from 9eeb07c to ff21498 Compare May 2, 2023 14:41
@MichaelDeBoey MichaelDeBoey removed the needs-response We need a response from the original author about this issue/PR label May 2, 2023
@brophdawg11
Copy link
Contributor

@jacob-ebey Does this look ok to you?

@MichaelDeBoey
Copy link
Member

Superseded by #6512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

instanceof Request on cloned request return false
5 participants