Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instanceof Request on cloned request return false #5520

Closed
1 task done
tomer-rmor opened this issue Feb 19, 2023 · 1 comment
Closed
1 task done

instanceof Request on cloned request return false #5520

tomer-rmor opened this issue Feb 19, 2023 · 1 comment
Labels
bug:unverified feat:fetch Issues related to @remix-run/web-fetch

Comments

@tomer-rmor
Copy link

What version of Remix are you using?

1.13.0

Are all your remix dependencies & dev-dependencies using the same version?

  • Yes

Steps to Reproduce

export async function action({ request }: ActionArgs) {
  const cloned = request.clone()
  if (cloned instanceof Request) { // return false
    console.log("")
  }
}

Expected Behavior

should return true

Actual Behavior

return false

@github-actions github-actions bot added the needs-response We need a response from the original author about this issue/PR label Apr 20, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 27, 2023
@remix-run remix-run deleted a comment from github-actions bot Apr 30, 2023
@remix-run remix-run deleted a comment from github-actions bot Apr 30, 2023
@machour machour reopened this Apr 30, 2023
@machour machour removed the needs-response We need a response from the original author about this issue/PR label Apr 30, 2023
@brophdawg11 brophdawg11 added the feat:fetch Issues related to @remix-run/web-fetch label May 4, 2023
@jacob-ebey
Copy link
Member

Thank you @tomer-rmor. I have merged this as part of #6512 with updated tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:unverified feat:fetch Issues related to @remix-run/web-fetch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants