Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(remix-dev/cli/init): add --no-delete flag #3573

Merged
merged 1 commit into from
Jul 2, 2022
Merged

feat(remix-dev/cli/init): add --no-delete flag #3573

merged 1 commit into from
Jul 2, 2022

Conversation

MichaelDeBoey
Copy link
Member

Follow-up of #3571

@MichaelDeBoey MichaelDeBoey force-pushed the add-no-delete-flag-to-init-command branch from a407916 to 91fd1b9 Compare June 29, 2022 16:39
kentcdodds
kentcdodds approved these changes Jul 2, 2022
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Thanks 👍

@kentcdodds
Copy link
Member

Rats. I took too long reviewing. Could you handle the merge conflict?

@MichaelDeBoey MichaelDeBoey force-pushed the add-no-delete-flag-to-init-command branch from 91fd1b9 to f846051 Compare July 2, 2022 13:18
@MichaelDeBoey MichaelDeBoey requested a review from kentcdodds July 2, 2022 13:19
@MichaelDeBoey MichaelDeBoey force-pushed the add-no-delete-flag-to-init-command branch from f846051 to fe05935 Compare July 2, 2022 13:31
kentcdodds
kentcdodds approved these changes Jul 2, 2022
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit 5aa1047 into remix-run:dev Jul 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2022

🤖 Hello there,

We just published version v0.0.0-nightly-2a1b3fb-20220703 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@MichaelDeBoey MichaelDeBoey deleted the add-no-delete-flag-to-init-command branch July 3, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcansh mcansh mcansh approved these changes

@kentcdodds kentcdodds kentcdodds approved these changes

@machour machour machour approved these changes

Assignees
No one assigned
Labels
CLA Signed package:dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MichaelDeBoey @kentcdodds @machour @mcansh