Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-dev/cli/init): always remove remix.init folder #3571

Merged

Conversation

MichaelDeBoey
Copy link
Member

This is important if people run npx remix init themselves, like suggested in remix-run/indie-stack#112, remix-run/blues-stack#89 & remix-run/grunge-stack#76

@mcansh
Copy link
Collaborator

mcansh commented Jun 25, 2022

that's fair i think, but can we maybe some kind of --dry-run flag to not delete it?

@MichaelDeBoey
Copy link
Member Author

@mcansh having a --dry/--dry-run flag would mean we shouldn't run remix.init as well, but log what's going to be changed instead.

I think a --no-delete/--no-remove flag would be better a better name in this case.

@MichaelDeBoey MichaelDeBoey force-pushed the always-remove-remix-init-folder branch from 752e96c to 67c5d00 Compare June 25, 2022 00:31
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep 👍 Thanks! Adding a --no-delete flag or something could be helpful for testing, but let's get this merged now.

@kentcdodds kentcdodds merged commit 19b32f4 into remix-run:dev Jun 25, 2022
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-19b32f4-20220625 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@MichaelDeBoey MichaelDeBoey deleted the always-remove-remix-init-folder branch June 25, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants