feat(remix-dev): import .sql files as text
#3190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiodxa
approved these changes
May 14, 2022
MichaelDeBoey
changed the title
.sql files as text.sql files as text
MichaelDeBoey
approved these changes
May 14, 2022
sergiodxa
reviewed
May 15, 2022
| @@ -22,6 +22,7 @@ export const loaders: { [ext: string]: esbuild.Loader } = { | |||
| ".ogg": "file", | |||
| ".otf": "file", | |||
| ".png": "file", | |||
| ".sql": "text", | |||
There was a problem hiding this comment.
Suggested change
| ".sql": "text", | |
| ".sql": "text", | |
| ".gql": "text", |
What do you think about also adding .gql as text? That will let people import a .gql file with a GraphQL query/mutation/subscription and then use it as a variable directly in their code
There was a problem hiding this comment.
Let's do a separate PR for that.
MichaelDeBoey
force-pushed
the
sql-text-import
branch
from
4a3f9a2 to
f0bdb35
Compare
🦋 Changeset detectedLatest commit: 93afee6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mcansh
pushed a commit
that referenced
this pull request
Aug 11, 2022
MichaelDeBoey
added
the
awaiting release
MichaelDeBoey
removed
the
awaiting release
This was referenced Oct 13, 2023
This was referenced Feb 18, 2024
This was referenced Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to import
.sqlfiles as text. This is useful when writing raw SQL instead of using an ORM.