Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix-dev): import .gql & .graphql files as text #3923

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

MichaelDeBoey
Copy link
Member

Follow-up of #3190 (comment)

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2022

🦋 Changeset detected

Latest commit: d07c1df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Major
create-remix Major
remix Major
@remix-run/eslint-config Major
@remix-run/react Major
@remix-run/serve Major
@remix-run/server-runtime Major
@remix-run/cloudflare Major
@remix-run/node Major
@remix-run/deno Major
@remix-run/cloudflare-pages Major
@remix-run/cloudflare-workers Major
@remix-run/express Major
@remix-run/netlify Major
@remix-run/vercel Major
@remix-run/architect Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MichaelDeBoey MichaelDeBoey force-pushed the import-gql-files-as-text branch from 1f85d39 to e147496 Compare August 4, 2022 11:27
@sergiodxa
Copy link
Member

I think this should be as text not as file

As file will give you the path to the file, as text will give you the content as a string

I think what users will want is to get the query string as a text so it can be used directly to send a query to the API, if you get a path to a file you will have to read it, and AFAIK the path will be a URL

@MichaelDeBoey MichaelDeBoey force-pushed the import-gql-files-as-text branch from e147496 to 7f66124 Compare August 4, 2022 17:23
@MichaelDeBoey
Copy link
Member Author

@sergiodxa Oops a bit too quick here 😅🙈

Should be good now

@machour
Copy link
Collaborator

machour commented Aug 4, 2022

@MichaelDeBoey shouldn't packages/remix-dev/modules.ts be updated too?

@MichaelDeBoey
Copy link
Member Author

@machour it wasn't updated in #3190, but it should I think?

CC/ @jacob-ebey

@MichaelDeBoey MichaelDeBoey force-pushed the import-gql-files-as-text branch 2 times, most recently from 279d82d to 603fae5 Compare August 8, 2022 22:50
@jacob-ebey
Copy link
Member

@machour it wasn't updated in #3190, but it should I think?

CC/ @jacob-ebey

Yes, it should be updated.

@MichaelDeBoey MichaelDeBoey force-pushed the import-gql-files-as-text branch from 603fae5 to d07c1df Compare August 11, 2022 18:55
@MichaelDeBoey
Copy link
Member Author

@jacob-ebey This should be fine to merge now

@jacob-ebey jacob-ebey merged commit 44fcb72 into remix-run:dev Aug 12, 2022
@MichaelDeBoey MichaelDeBoey deleted the import-gql-files-as-text branch August 12, 2022 17:47
@MichaelDeBoey MichaelDeBoey added the awaiting release This issue has been fixed and will be released soon label Aug 15, 2022
@MichaelDeBoey MichaelDeBoey removed the awaiting release This issue has been fixed and will be released soon label Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants