-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remix-dev): import .gql
& .graphql
files as text
#3923
feat(remix-dev): import .gql
& .graphql
files as text
#3923
Conversation
🦋 Changeset detectedLatest commit: d07c1df The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1f85d39
to
e147496
Compare
I think this should be as text not as file As file will give you the path to the file, as text will give you the content as a string I think what users will want is to get the query string as a text so it can be used directly to send a query to the API, if you get a path to a file you will have to read it, and AFAIK the path will be a URL |
e147496
to
7f66124
Compare
@sergiodxa Oops a bit too quick here 😅🙈 Should be good now |
@MichaelDeBoey shouldn't |
@machour it wasn't updated in #3190, but it should I think? CC/ @jacob-ebey |
279d82d
to
603fae5
Compare
Yes, it should be updated. |
603fae5
to
d07c1df
Compare
@jacob-ebey This should be fine to merge now |
Follow-up of #3190 (comment)