-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
capital / consumption jumps between Nov / Dec 2022 #1276
Comments
Changes of this PR seem to be mostly energy system related. It would be surprising that this should cause such macro change. My suspect would be the change of the CES parameters (probably derived from a new calibration which itself could be include a number of different changes from previous PRs). Also the inputRevision number changes. Could there be an issue with new input data? |
@mleimbach @orichters How are the 2005 non-ESM capital stocks determined in REMIND? are they an input data to which the variable is fixed? |
I have to remind myself. So without guarantee: capital stocks are free, but more or less predetermined by the calibration which provides the (share and) efficiency parameters of capital. The calibration routine changed over the years. I am not sure how it works actually. But there is some capital stock specific information included: either a capital price that can be determined based on an assumed capital income share and a capital coefficient (K/Y) or a given capital stock trajectory that is based on given GDP and K/Y. |
Non-ESM capital (everything in Calibration input:
Calibration output:
So that changed between
pik-piam/mrremind#307 and pik-piam/mrremind#328. That makes for 18 merge requests into
|
I guess I will look at pik-piam/mrremind#306 … |
Thanks Michaja. Thus, it is quite likely that the jumps are caused by a change of capital stock input data with non-ESM capital showing the largest difference. Could anybody already detect in which of the considered PRs this change is hidden? |
Aaand we're fucked. |
We unfortunately don't have a switch to hop between old and new data, so I'd agree with the point-of-no-return phrasing. We could implement it if needed, but would involve extensive validation of the interplay of old data with all the libraries (as it affects many calc functions). Other than that, I can only think of jumping back to the latest mrremind/mrcommons versions before the switch. |
Well, pik-piam/mrremind#306 seems to be the only thing touching on the capital stocks, judging from the merge request messages (which are not always … comprehensive, shall we say?) The energy efficiency capital (EEK) is subtracted from the general capital stock, to avoid double counting. There was a bug with too much EEK, but the jump in I'm not sure if something, and if so, what, in pik-piam/mrremind#306 could have caused the difference in But as it is questionable whether or when we will get a definitive answer on what caused the change, we should maybe think along different lines, too.
So, why did 2005 investments not change? If we are not married to the precise consumption path, only to the idea of an kink-free consumption path, having "smooth" investments from 2005 on might be the way to go. |
I agree with Michaja's last proposal (smoothing 2005 investments). Investments in 2005 are currently fixed to an "empirical" value (which we may have to check). It probably does not fit to the new initial capital stock. HOWEVER, where does the change in the capital stock estimation comes from ??? |
Well, it's "real" world data (PWT investment shares). And it didn't really fit the the investments REMIND is doing before hand, but it did work out to a smooth behaviour.
Guess I will dissect that. |
Before anything industry-related is happening, |
Is there anything I can do at the moment? Staring at the source code doesn't seem to work, and I miss the "how to debug input data errors" tutorial that would help me where to start :) |
Michaja, thank you very much for digging deep and localizing the source of the problem. Now Macro has to do its homework. |
fixed with pik-piam/mrdrivers#67 |
FYI @robertpietzcker, @mleimbach, @LaviniaBaumstark, @aodenweller, @fschreyer.
End of November/beginning of December 2022, the calibration changed substantially, affecting consumption, investment and capital stock behavior.
Capital stocks increased:
Consumption shows a significant drop after 2005:
Investment is higher:
Somehow, the CES parameters changed substantially, for example in REF, but also in EUR, as extracted with the small script attached. The relevant AMT runs in
/p/projects/remind/modeltests/output/
are:SSP2EU-AMT-Base_2022-11-26_00.08.52
vs.SSP2EU-AMT-Base_2022-12-03_00.12.29
SSP2EU-AMT-calibrate_2022-11-26_00.07.54
vs.SSP2EU-AMT-calibrate_2022-12-03_00.10.49
Dear colleagues, it would be awesome if someone with a better intuition about what affects the calibration would have a look at this PR that I suspect may be causing the issue of consumption drop and investment spike in the 2010–2020 years, see attached document.
Somehow, the CES parameter changed substantially, for example in REF, but also in EUR, as extracted with the small script attached. The relevant runs are
/p/projects/remind/modeltests/output/SSP2EU-AMT-Base_2022-11-26_00.08.52
andSSP2EU-AMT-Base_2022-12-03_00.12.29
, respectively theSSP2EU-AMT-calibrate_2022-11-26_00.07.54
/SSP2EU-AMT-calibrate_2022-12-03_00.10.49
runs.A full compareScenarios2 is available at
/p/tmp/oliverr/remind/compScen-consumption_issue-2023-03-31_13.11.07-H12.pdf
.Here is a comparison of all the changes between the
SSP2EU-AMT-Base_2022-11-26
run and the2022-12-03
run: https://github.com/remindmodel/remind/compare/81264e35..a3eb6ac7?w=1My suspicion is this PR, but I'm not entirely sure.
The text was updated successfully, but these errors were encountered: