Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplication of scenarios due to imprecise filtering. #320

Merged
merged 5 commits into from
Sep 28, 2022

Conversation

Loisel
Copy link
Contributor

@Loisel Loisel commented Sep 27, 2022

Some of the scenarios would be duplicated in the old version.

The new version yields the following combinations:
Screenshot from 2022-09-28 11-55-38 354670347

@Loisel Loisel requested a review from johannah-pik September 27, 2022 21:43
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (94d5761) compared to base (e0a8968).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #320   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         254     254           
  Lines       16724   16727    +3     
======================================
  Hits            1       1           
- Misses      16723   16726    +3     
Impacted Files Coverage Δ
R/readEDGETransport.R 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Loisel Loisel marked this pull request as ready for review September 28, 2022 09:53
Copy link
Contributor

@johannah-pik johannah-pik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schaut gut aus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants