-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
calcCapital() results differ between 1242136 and 298465a, and nobody knows why #385
Comments
Thanks, @0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q, very helpful! This change in calcGDPPast() in mrdrivers seems to change old GDP numbers substantially:
So I guess this might be the reason. |
My suspicion:
PENN World Table data is read from this file called
So I don't think this data should be converted from 2017 to 2005 data. The PR does not show an explanation why this is the case, so I would rather revert this change. |
Oliver, with conversion, GDP in 2005US$ becomes lower. I am still confused why we than see higher capital stocks (assuming that we apply the same capital intensity factors). |
This line calculates the capital/GDP ratio based on PWT. If historical GDP is lower, then capital/GDP is higher. If you multiply that with your desired SSP2 GDP, you get a higher capital stock. So the error was in the calculation of the capital intensity factor which was inflated because of the bug. |
Ok,capital intensity changes. Makes sense. |
solved with pik-piam/mrdrivers#67 |
Originates from remindmodel/remind#1276.
calcCapital()
mrremind/R/calcCapital.R
Lines 21 to 28 in 8261c7f
mrremind/R/calcCapital.R
Line 32 in 8261c7f
So it appears that 1242136 and 298465a used different "
gdpppp_hist
" for transforming capital intensities back into capital stocks. That, however, is not due to a change incalcCapital()
in that timeframe.mrdrivers
moved from 0.6.6 (pik-piam/mrdrivers#49) to 0.7.2 (pik-piam/mrdrivers#54) in the meantime, so maybe answers lie that way.The text was updated successfully, but these errors were encountered: