Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH version migrator refactor #807

Merged
merged 9 commits into from
Feb 23, 2020
Merged

Conversation

beckermr
Copy link
Contributor

@beckermr beckermr commented Feb 15, 2020

Fixing bugs and trying again

Reverts #805

Closes #802
Closes #803

@codecov
Copy link

codecov bot commented Feb 15, 2020

Codecov Report

Merging #807 into master will increase coverage by 0.12%.
The diff coverage is 44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #807      +/-   ##
==========================================
+ Coverage   59.61%   59.74%   +0.12%     
==========================================
  Files          32       32              
  Lines        3202     3294      +92     
==========================================
+ Hits         1909     1968      +59     
- Misses       1293     1326      +33
Impacted Files Coverage Δ
conda_forge_tick/auto_tick.py 0% <0%> (ø) ⬆️
tests/test_upstream_versions.py 100% <100%> (ø) ⬆️
conda_forge_tick/migrators/matplotlib_base.py 95.12% <100%> (+3.81%) ⬆️
conda_forge_tick/migrators/version.py 87.41% <100%> (+0.04%) ⬆️
conda_forge_tick/make_graph.py 38.65% <16.66%> (-1.78%) ⬇️
conda_forge_tick/migrators/core.py 75.21% <33.33%> (-0.23%) ⬇️
conda_forge_tick/update_upstream_versions.py 30.71% <42.5%> (+6.26%) ⬆️
conda_forge_tick/utils.py 60.99% <75%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32adbec...81c8b7a. Read the comment docs.

@scopatz
Copy link
Contributor

scopatz commented Feb 18, 2020

There is a lot going on here, but it generally looks good to me! Any objections to merging this?

@beckermr
Copy link
Contributor Author

Sorry yeah this one got out of hand. :/

No objections - I reverted it a few times due to bugs

@beckermr beckermr merged commit faa0755 into master Feb 23, 2020
@beckermr beckermr deleted the revert-805-revert-800-ver-refactor branch February 23, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong build number bump missed upstream extension for a url
4 participants