ENH version migrator refactor #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckermr
commented
Feb 14, 2020
| @@ -16,8 +16,7 @@ | |||
| ('multisrc', '2.4.1'), | |||
| ('jinja2sha', '2.4.1'), | |||
| ('r', '1.3_2'), | |||
| # FIXME - this test was being skipped by accident - now fails | |||
| # ('cb3multi', '6.0.0'), | |||
| ('cb3multi', '6.0.0'), | |||
There was a problem hiding this comment.
And now this test passes!
beckermr
commented
Feb 14, 2020
| @@ -1,4 +1,3 @@ | |||
| {# cb3_multi #} | |||
There was a problem hiding this comment.
ruamel.yaml cannot deal with jinja2 comments...
Codecov Report
@@ Coverage Diff @@
## master #800 +/- ##
==========================================
+ Coverage 55.88% 58.59% +2.71%
==========================================
Files 32 32
Lines 3375 3111 -264
==========================================
- Hits 1886 1823 -63
+ Misses 1489 1288 -201
Continue to review full report at Codecov.
|
beckermr
force-pushed
the
ver-refactor
branch
from
bbba695 to
3411f13
Compare
mariusvniekerk
approved these changes
Feb 15, 2020
beckermr
added a commit
that referenced
this pull request
Feb 15, 2020
beckermr
added a commit
that referenced
this pull request
Feb 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a refactor of the version migrator using the parsing from #795. This approach should allow us to close out various version migration issues for complicated recipes.
Closes #794
Closes #762
Closes #781
Closes #500
Closes #529
Closes #430