Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add percentage on project creation #2082

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

flagrede
Copy link
Collaborator

@flagrede flagrede commented Sep 6, 2023

Description

Closes: regen-network/rnd-dev-team#955

  • compute progress percentage on project creation

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

  1. https://deploy-preview-2082--regen-marketplace.netlify.app/project-pages/3060b6b6-4cbb-11ee-961a-0267c2be097b/basic-info

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@netlify
Copy link

netlify bot commented Sep 6, 2023

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit acc7cfc
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/64f9e8837d9faf0008759ff1
😎 Deploy Preview https://deploy-preview-2082--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flagrede
Copy link
Collaborator Author

flagrede commented Sep 6, 2023

@flagrede flagrede requested a review from a team September 6, 2023 13:42
@erikalogie
Copy link
Collaborator

looks great!

Copy link
Member

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@flagrede flagrede force-pushed the feat-955-progress-bar-project-creation branch 2 times, most recently from dc17ce8 to 896e6f7 Compare September 7, 2023 12:15
@flagrede flagrede force-pushed the feat-955-progress-bar-project-creation branch from 896e6f7 to acc7cfc Compare September 7, 2023 15:13
@flagrede flagrede merged commit 4d78142 into dev Sep 7, 2023
@flagrede flagrede deleted the feat-955-progress-bar-project-creation branch September 7, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compute progress bar percentage on Project creation form footers
3 participants