Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute progress bar percentage on Project creation form footers #955

Closed
2 of 3 tasks
blushi opened this issue Jun 1, 2022 · 2 comments · Fixed by regen-network/regen-web#2082
Closed
2 of 3 tasks
Assignees
Labels
dev Engineering tasks

Comments

@blushi
Copy link
Member

blushi commented Jun 1, 2022

Describe the solution you'd like
This will need to be done for the project creation flow (credit class and credit batch creation flows handled separately)
Right now, the percentage is just set as 0.

Ref: https://github.com/regen-network/regen-web/blob/616f2525f924ad8b9262ee30c2b025ae1b6711e5/web-components/src/components/fixed-footer/OnboardingFooter.tsx#L45-L50

Given the fact that the project creation flow uses different pages per form while the credit batch/class creation flows use a single page for the whole flow with internal state for managing steps, we might need different approaches.

Figma design for this forms (see green progress bar at the very bottom):
https://www.figma.com/file/TyhFaXqko9F8OvLEE4Zomg/Issuer-Create%2FEdit-Projects%2C-Credit-Class%2C-Batches?node-id=69%3A22030
https://www.figma.com/file/TyhFaXqko9F8OvLEE4Zomg/Issuer-Create%2FEdit-Projects%2C-Credit-Class%2C-Batches?node-id=19%3A11657
https://www.figma.com/file/TyhFaXqko9F8OvLEE4Zomg/Issuer-Create%2FEdit-Projects%2C-Credit-Class%2C-Batches?node-id=0%3A1


For Admin Use

  • Not duplicate issue
  • Appropriate labels and zenhub epics applied
  • Appropriate contributors tagged
@blushi blushi added the dev Engineering tasks label Jun 1, 2022
@blushi blushi changed the title Implement progress bar percentage on form footers Compute progress bar percentage on form footers Jun 1, 2022
@blushi blushi changed the title Compute progress bar percentage on form footers Compute progress bar percentage on Project creation form footers Jun 14, 2022
@S4mmyb S4mmyb closed this as completed May 15, 2023
@erikalogie erikalogie reopened this Jun 13, 2023
@ryanchristo
Copy link
Member

Hey team! Please add your planning poker estimate with Zenhub @flagrede @blushi

@flagrede flagrede self-assigned this Sep 6, 2023
@flagrede
Copy link

flagrede commented Sep 6, 2023

I wasn't aware we already had the UI for this, I'm fine with 2 in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Engineering tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants