-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to httpx
(#74)
#75
Conversation
Code looks good, I'll look into the Github Actions failure... we can merge once it's passing |
I know why the CI is failed. Poetry just released a new version of lock file, and I use the latest version. When I run Update the Poetry v1.3.0 release log: https://github.com/python-poetry/poetry/releases/tag/1.3.0 The PR of lockfile change: python-poetry/poetry#6393 |
I got some error when I try to push the commit to my repo:
Don't know how to deal with it, my change: # .github/workflows/build.yml, line 28
- name: cache poetry install
uses: actions/cache@v2
with:
path: ~/.local
key: python-${{ matrix.python-version }}-poetry-1.2.2-0
- uses: snok/install-poetry@v1
with:
version: 1.2.2
virtualenvs-create: true
virtualenvs-in-project: true |
I think you may not be able to update the CI jobs - I'll push a PR updating it with the poetry version, then we can merge this. |
Thanks good catch |
@FHU-yezi I just pushed a PR updating the poetry version, could you rebase this on top and push? Hopefully the build passes this time. Btw, thanks for all your contributions and involvement with the project so far! |
Just rebased my branch with the newest commits, and now the CI is running... But it failed again. |
Read By the way, I removed some All CI show me the green light, we are about to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome
No description provided.