feat: lock file format 2.0 (was: store package files on the package in lockfile) #6393
Conversation
dimbleby
force-pushed
the
package-files-belong-on-package
branch
3 times, most recently
from
51ab32a to
6dc4c51
Compare
src/poetry/packages/locker.py
Outdated
| @@ -241,6 +250,7 @@ def set_lock_data(self, root: Package, packages: list[Package]) -> bool: | |||
| "lock-version": self._VERSION, | |||
| "python-versions": root.python_versions, | |||
| "content-hash": self._content_hash, | |||
| # TODO stop writing files here, this is deprecated. | |||
There was a problem hiding this comment.
If we bump the lock-version, there is no reason to keep writing files here, isn't it?
There was a problem hiding this comment.
Depends whether we're ready to make a breaking change or not.
If we stop writing files here then the version should go 2.0, so that down-level poetry knows that it can't read it.
I was expecting that we'd go 1.2 now, and 2.0 at some later point, but am happy to be told otherwise.
There was a problem hiding this comment.
Ah ok, I thought that any version bump makes it unreadable for older poetry. (I didn't look into the code.)
I have concerns that the lockfile size will increase significantly if we write the information twice. It seems we can only choose between the devil and the deep blue sea... I think we have to discuss that among maintainers.
There are already tests using the Given that even that doesn't use the even-older format I think it might actually be about time to remove the code that reads it. Looks like it was removed at b1c4c68, three years ago, it's probably reasonable for the next poetry release to finally drop support for that - there must be approximately zero examples left in the wild. |
|
it turns out poetry's own unit tests use the old lockfile format, I've updated them to the 2019 vintage in this MR and also in python-poetry/poetry-plugin-export#119 Updating them to use the format proposed here is more tedious, I'm inclined to say that we can live without doing that. Anyway it might be some time before I can work up enthusiasm for the task... |
dimbleby
force-pushed
the
package-files-belong-on-package
branch
from
fa06230 to
808ecbc
Compare
neersighted
added
area/solver
dimbleby
force-pushed
the
package-files-belong-on-package
branch
from
808ecbc to
21248f7
Compare
|
it occurs to me that another thing that could be done to soften the blow of changing the file format would be to backport the reading (but not the writing) part of the change to 1.2. Maybe that would make it more palatable to do the breaking change all in one go, with no intermediate write-everything-in-two-places
being forced to |
|
I like the idea. 👍 |
|
pushed a commit to go straight to 2.0 in this MR, and remove the old #6608 is the proposed backport to 1.2. |
neersighted
changed the title
radoering
removed
the
status/needs-consensus
Backport the ability to read 2.0 lockfiles per #6393
Bringing them to 2019's format...
don't write package files out twice
radoering
force-pushed
the
package-files-belong-on-package
branch
from
76f1850 to
e7f7f46
Compare
the reason for this change is to keep the old lock file format and avoid incompatibility with version in main of F1ashhimself/electricitybot later on version can be changed to 1.3.1 or any other later version (requrie changes in .github/workflows/app.yaml, Dockerfile and update version on local enviroment) python-poetry/poetry#6393
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
counter-proposal to #6389, per #6389 (comment)
doesn't quite fix #6327, we continue to write the unwanted extra metadata.files line to the lockfile until some future point where we stop writing that section at alldoes fix #6327 after all now I think harder about it, the unwanted files and hashes don't get wrongly attached to the URL package after thisalso fixes #6349, installing a URL package doesn't care any more about files and hashes from other packages.