Use goreleaser for rpk releases #7115

ivotron · 2022-11-07T06:29:05Z

Use goreleaser for creating/publishing RPK binaries. To test locally, install goreleaser and then:

cd src/go/rpk
goreleaser r --rm-dist --snapshot

The --snapshot above makes the build skip notarization for darwin binaries.

fixes #2773
fixes https://github.com/redpanda-data/devprod/issues/443
related to #4191
related to redpanda-data/homebrew-tap#9

Backport Required

v22.2.x
v22.1.x

Release notes

none

ivotron · 2022-11-07T06:35:24Z

required secrets have been defined for this repository

ivotron · 2022-11-07T06:58:21Z

a GHA job run that tests these changes: https://github.com/ivotron/redpanda/actions/runs/3408138014/jobs/5668439346 . this is running on my fork repo, where I added the same secrets and changed the org references from redpanda-data to ivotron (see ivotron@51d64b0)

I triggered using the v20.0.0 tag (which doesn't exist in this repo). The two main outcomes:

A draft github release: https://github.com/ivotron/redpanda/releases/tag/untagged-9a3b84ad34b1afac56f6
A commit to the homebrew-tap repo ivotron/homebrew-tap@ed5204c . Note that on my fork this commit goes directly to the main branch but in our repo this is not the case, and a PR is opened first due to branch protection rules

To test the tap:

brew tap ivotron/homebrew-tap

# verify the info
brew info ivotron/tap/redpanda

# on an M1 mac, this will attempt to fetch the arm64 binary
brew install ivotron/tap/redpanda

since the release is marked draft, the messages is:

$ brew install ivotron/tap/redpanda
==> Downloading https://github.com/ivotron/redpanda/releases/download/v20.0.0/rpk_20.0.0_darwin_arm64.tar.gz
curl: (22) The requested URL returned error: 404

Error: redpanda: Failed to download resource "redpanda"
Download failed: https://github.com/ivotron/redpanda/releases/download/v20.0.0/rpk_20.0.0_darwin_arm64.tar.gz

but this shows how the arm64 binary is being referenced

ivotron · 2022-11-07T07:22:18Z

I pushed a v20.0.01 tag to my fork and published that release, so that I could install rpk, and the install works fine, meaning the arm64 binary gets installed on my m1, and runs fine. The problem I found is that rpk version shows an empty string. I'll mark this as draft until this gets resolved. However, I would really appreciate reviews for this in its current state, as I don't expect the PR to change drastically (it'll be a small tweak to the goreleaser config).

src/go/rpk/.goreleaser.yaml

twmb · 2022-11-09T20:35:31Z

src/go/k8s/cmd/configurator/main_test.go

-	fs := afero.NewOsFs()
-	p := config.Params{ConfigPath: ""}
-	cfg, err := p.Load(fs)
-	if err != nil {
-		log.Fatalf("%s", fmt.Errorf("unable to read the redpanda configuration file: %w", err))
-	}


Why this change?

Nvm, this is from #7107, can this be rebased on dev?

twmb · 2022-11-09T20:38:59Z

src/go/k8s/cmd/configurator/main.go

+	p := path.Join(c.configSourceDir, "redpanda.yaml")
+	cf, err := os.ReadFile(p)
 	if err != nil {
-		log.Fatalf("%s", fmt.Errorf("unable to read the redpanda configuration file: %w", err))
+		log.Fatalf("%s", fmt.Errorf("unable to read the redpanda configuration file, %q: %w", p, err))
+	}
+	cfg := &config.Config{}
+	err = yaml.Unmarshal(cf, cfg)
+	if err != nil {
+		log.Fatalf("%s", fmt.Errorf("unable to parse the redpanda configuration file, %q: %w", p, err))


This is from #7107 as well (and the go.mod change)

yes, sorry, the rebase is a bit messed up. fixed in the last push

src/go/rpk/.goreleaser.yaml

the goreleaser configuration added in this commit defines the following: - builds for windows and darwin, to replicate the previous github actions-based workflow - homebrew release, which takes care of publishing M1 binaries - for the darwin build, hooks for signing/notarizing using quill - github release that replicates the github actions-based workflow for uploading rpk binaries as github release artifacts Signed-off-by: Ivo Jimenez <[email protected]>

- installs quill instead of gon, as this is what's used now for signing/notarization of darwin binaries. - moves logic of github/homebrew releases to goreleaser's Signed-off-by: Ivo Jimenez <[email protected]>

These are now unused. Signed-off-by: Ivo Jimenez <[email protected]>

emaxerrno · 2022-11-14T05:23:50Z

@ivotron what’s the motivation for this change. To create a separate rpk release train ?

ivotron · 2022-11-14T06:34:57Z

@ivotron what’s the motivation for this change. To create a separate rpk release train ?

the main goal is to fix #2773. goreleaser takes care of that nicely. As a side effect, it opens the possibility of being able to publish standalone rpk binaries for linux (just add it as a new os/arch combination), as well as for homebrew on linux

ivotron · 2022-12-04T12:18:19Z

/backport v22.3.x

ivotron · 2022-12-09T04:07:18Z

/backport v22.2.x

ivotron · 2022-12-09T04:07:26Z

/backport v22.1.x

vbotbuildovich · 2022-12-09T04:08:17Z

Failed to run cherry-pick command. I executed the below command:

git cherry-pick -x 529166e03fca50745bbe22c6a2df8c3f5d02ce25 e4f151e8f7061ce23fee2292d497691465d2947e c553d8c5bcca317cb26d17427fa3bac3cd9c7592

Workflow run logs.

vbotbuildovich · 2022-12-09T04:08:30Z

Failed to run cherry-pick command. I executed the below command:

git cherry-pick -x 529166e03fca50745bbe22c6a2df8c3f5d02ce25 e4f151e8f7061ce23fee2292d497691465d2947e c553d8c5bcca317cb26d17427fa3bac3cd9c7592

Workflow run logs.

freef4ll · 2022-12-14T15:54:47Z

Please note that Brew can't install 22.3.6: #7757

ivotron requested a review from andrewhsu November 7, 2022 06:29

ivotron requested review from twmb, 0x5d, r-vasquez and a team as code owners November 7, 2022 06:29

github-actions bot added area/build area/k8s area/rpk labels Nov 7, 2022

ivotron mentioned this pull request Nov 7, 2022

Add rpk standalone installscript for OSX,Linux #4191

Open

rishabh96b reviewed Nov 8, 2022

View reviewed changes

src/go/rpk/.goreleaser.yaml Show resolved Hide resolved

twmb reviewed Nov 9, 2022

View reviewed changes

src/go/rpk/.goreleaser.yaml Show resolved Hide resolved

ivotron added 3 commits November 10, 2022 00:08

gha/rpk: use goreleaser for publishing rpk binaries

e4f151e

- installs quill instead of gon, as this is what's used now for signing/notarization of darwin binaries. - moves logic of github/homebrew releases to goreleaser's Signed-off-by: Ivo Jimenez <[email protected]>

rpk: remove gon config and GHA workflow files

c553d8c

These are now unused. Signed-off-by: Ivo Jimenez <[email protected]>

ivotron force-pushed the use-goreleaser-for-rpk-releases branch from 0e71d97 to c553d8c Compare November 10, 2022 07:08

github-actions bot removed the area/k8s label Nov 10, 2022

ivotron requested review from rishabh96b and twmb November 10, 2022 07:10

twmb approved these changes Nov 13, 2022

View reviewed changes

rishabh96b approved these changes Nov 16, 2022

View reviewed changes

ivotron merged commit 8f86dee into redpanda-data:dev Dec 4, 2022

ivotron deleted the use-goreleaser-for-rpk-releases branch December 4, 2022 12:16

This was referenced Dec 4, 2022

[v22.3.x] brew/mac: Install the M1 rpk version on M1 macs #7622

Closed

[v22.3.x] Use goreleaser for rpk releases #7623

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use goreleaser for rpk releases #7115

Use goreleaser for rpk releases #7115

ivotron commented Nov 7, 2022 •

edited

Loading

ivotron commented Nov 7, 2022 •

edited

Loading

ivotron commented Nov 7, 2022 •

edited

Loading

ivotron commented Nov 7, 2022

twmb Nov 9, 2022

twmb Nov 9, 2022

twmb Nov 9, 2022

ivotron Nov 10, 2022

emaxerrno commented Nov 14, 2022

ivotron commented Nov 14, 2022

ivotron commented Dec 4, 2022

ivotron commented Dec 9, 2022

ivotron commented Dec 9, 2022

vbotbuildovich commented Dec 9, 2022

vbotbuildovich commented Dec 9, 2022

freef4ll commented Dec 14, 2022

Use goreleaser for rpk releases #7115

Use goreleaser for rpk releases #7115

Conversation

ivotron commented Nov 7, 2022 • edited Loading

Backport Required

Release notes

ivotron commented Nov 7, 2022 • edited Loading

ivotron commented Nov 7, 2022 • edited Loading

ivotron commented Nov 7, 2022

twmb Nov 9, 2022

Choose a reason for hiding this comment

twmb Nov 9, 2022

Choose a reason for hiding this comment

twmb Nov 9, 2022

Choose a reason for hiding this comment

ivotron Nov 10, 2022

Choose a reason for hiding this comment

emaxerrno commented Nov 14, 2022

ivotron commented Nov 14, 2022

ivotron commented Dec 4, 2022

ivotron commented Dec 9, 2022

ivotron commented Dec 9, 2022

vbotbuildovich commented Dec 9, 2022

vbotbuildovich commented Dec 9, 2022

freef4ll commented Dec 14, 2022

ivotron commented Nov 7, 2022 •

edited

Loading

ivotron commented Nov 7, 2022 •

edited

Loading

ivotron commented Nov 7, 2022 •

edited

Loading