Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew/mac: Install the M1 rpk version on M1 macs #2773

Closed
rkruze opened this issue Oct 25, 2021 · 7 comments · Fixed by #7115
Closed

brew/mac: Install the M1 rpk version on M1 macs #2773

rkruze opened this issue Oct 25, 2021 · 7 comments · Fixed by #7115
Assignees
Labels
area/rpk kind/enhance New feature or request team/devprod display on zenhub workspace for devprod team

Comments

@rkruze
Copy link
Contributor

rkruze commented Oct 25, 2021

Currently, the homebrew recipe only installs the intel version of rpk. It should pick the right rpk package depending on the architecture that it is being installed on.

@ivotron ivotron self-assigned this Oct 25, 2021
@jcsp jcsp added the kind/enhance New feature or request label Nov 4, 2021
@twmb
Copy link
Contributor

twmb commented May 4, 2022

@ivotron can this be done by @r-vasquez? Is this to be done in vtools?

@ivotron
Copy link
Member

ivotron commented May 4, 2022

sure thing. this has te be done in github actions . this is the workflow that needs to be updated: https://github.com/redpanda-data/redpanda/blob/dev/.github/workflows/rpk-build.yml

@ivotron ivotron added the team/devprod display on zenhub workspace for devprod team label May 5, 2022
@r-vasquez
Copy link
Contributor

Related: #4851

@r-vasquez
Copy link
Contributor

Current rpk-build already builds, sign, and release for M1 (darwin/arm64) however the redpanda homebrew tap only use the intel version: https://github.com/redpanda-data/homebrew-tap/blob/main/Formula/redpanda.rb#L4

I'll make the change there.

@r-vasquez
Copy link
Contributor

Created: redpanda-data/homebrew-tap#1

@ivotron
Copy link
Member

ivotron commented May 23, 2022

ideally this needs to be automated. once that patch goes in, I think subsequent releases will fail next time the pipeline runs. instead, we can add support for pushing multiple artifacts by tweaking the github action https://github.com/mislav/bump-homebrew-formula-action

@ivotron ivotron removed their assignment Aug 2, 2022
@andrewhsu
Copy link
Member

It seems bump-homebrew-formula-action does not have provisions to update multiple architectures within a formula (see mislav/bump-homebrew-formula-action#5).

As an alternative, we could build a universal macOS binary. this is essentially a fat binary that is the combined filesize of the amd64 and arm64 binaries (~11MB total).

Or, we could use (or create) a different github action to update the homebrew formula.

Another approach could be to submit the formula to homebrew-core and keep the source code download up-to-date upon redpanda releases and let homebrew team compile the binaries. If it is accepted, the homebrew team would create bottle of binaries on macOS x86_64 and ARM and on x86_64 Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rpk kind/enhance New feature or request team/devprod display on zenhub workspace for devprod team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants