-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
brew/mac: Install the M1 rpk version on M1 macs #2773
Comments
@ivotron can this be done by @r-vasquez? Is this to be done in vtools? |
sure thing. this has te be done in github actions . this is the workflow that needs to be updated: https://github.com/redpanda-data/redpanda/blob/dev/.github/workflows/rpk-build.yml |
Related: #4851 |
Current I'll make the change there. |
Created: redpanda-data/homebrew-tap#1 |
ideally this needs to be automated. once that patch goes in, I think subsequent releases will fail next time the pipeline runs. instead, we can add support for pushing multiple artifacts by tweaking the github action https://github.com/mislav/bump-homebrew-formula-action |
It seems bump-homebrew-formula-action does not have provisions to update multiple architectures within a formula (see mislav/bump-homebrew-formula-action#5). As an alternative, we could build a universal macOS binary. this is essentially a fat binary that is the combined filesize of the Or, we could use (or create) a different github action to update the homebrew formula. Another approach could be to submit the formula to homebrew-core and keep the source code download up-to-date upon redpanda releases and let homebrew team compile the binaries. If it is accepted, the homebrew team would create |
Currently, the homebrew recipe only installs the intel version of rpk. It should pick the right rpk package depending on the architecture that it is being installed on.
The text was updated successfully, but these errors were encountered: