Decouple web terminal idle timeout from DevWorkspace idle timeout #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Set timeout for web terminals through an environment variable in the web-terminal-exec plugin rather than through the automatically provisioned DEVWORKSPACE_IDLE_TIMEOUT environment variable. This allows
the timeout for individual terminals to be changed without overriding the timeout for all DevWorkspaces
The main reason to update the idle timeout currently is that the bash history is erased when a Web Terminal is idled. By setting a longer duration, a session could continue for e.g. a full work day.
What issues does this PR fix or reference?
We've had a number of requests for how to increase the web terminal timeout, which normally requires editing the DevWorkspace Operator config or the
web-terminal-exec
. With these changes, it's easy to override the timeout for individual web terminals in a persistent way.Is it tested? How?
Start a web terminal with these changes and verify that the updated variable is used for idle timeout. To shorten it for the current web terminal, paste and execute the command