Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How does workspace idling timeout work in Eclipse Che with DW enabled? #21322

Closed
SkorikSergey opened this issue Apr 6, 2022 · 5 comments
Closed
Labels
area/devworkspace-operator area/editor/theia Issues related to the che-theia IDE of Che kind/question Questions that haven't been identified as being feature requests or bugs. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.

Comments

@SkorikSergey
Copy link
Contributor

Summary

How does workspace idling timeout work in Eclipse Che with DW enabled?

I tried to use next DevWorkspaceOperatorConfig object:

kind: DevWorkspaceOperatorConfig
apiVersion: controller.devfile.io/v1alpha1
metadata:
  name: devworkspace-operator-config
  namespace: openshift-operators
config:
  workspace:
    imagePullPolicy: Always
    idleTimeout: '1m'

After this object creation devworkspace-controller-manager pod updated configuration

{"level":"info","ts":1649081288.4094315,"logger":"operator-configuration","msg":"Updated config to [(default config)]"}
{"level":"info","ts":1649081310.787388,"logger":"operator-configuration","msg":"Updated config to [workspace.idleTimeout=3m]"} 

But workspace didn't stop after 3 min

{"level":"info","ts":1649084814.4158278,"logger":"controllers.DevWorkspace","msg":"Got conflict when trying to apply timing annotations to workspace","Request.Namespace":"opentlc-mgr-codeready","Request.Name":"cpp","devworkspace_id":"workspacef48ff8969efa4895"}
{"level":"info","ts":1649084814.4289684,"logger":"controllers.DevWorkspace","msg":"Error updating workspace status: Operation cannot be fulfilled on devworkspaces.workspace.devfile.io \"cpp\": the object has been modified; please apply your changes to the latest version and try again","Request.Namespace":"opentlc-mgr-codeready","Request.Name":"cpp","devworkspace_id":"workspacef48ff8969efa4895"}

Relevant information

Checked on Eclipse Che 7.45.0 on Openshift 4.9 deployed from OperatorHub.

@SkorikSergey SkorikSergey added the kind/question Questions that haven't been identified as being feature requests or bugs. label Apr 6, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Apr 6, 2022
@musienko-maxim
Copy link
Contributor

It is interesting - when I run the WebTerminal instance which also creates DevWorkspace under the hood this feature works as expected. The WebTerminal has been stopped according to the configuration

@dmytro-ndp dmytro-ndp added the area/editor/theia Issues related to the che-theia IDE of Che label Apr 6, 2022
@dmytro-ndp
Copy link
Contributor

@musienko-maxim: Web terminal idle timeout had been decoupled from DevWorkspace idle timeout 26 days ago: redhat-developer/web-terminal-operator#114

@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Apr 11, 2022
@l0rd
Copy link
Contributor

l0rd commented Apr 11, 2022

In Che the timeout is set in the definition of the editor. As a workaround you can point to an alternative editor definition (c.f. <che-URL>/dashboard/#https://github.com/che-samples/bash/tree/devfilev2?che-editor=https://gist.githubusercontent.com/vinokurig/8240d845067c89e295e2cb4dc2c0070b/raw/ad3452ee49b0eeddfaf086f55557d46206073fea/che-theia.yaml).

I will open an other issue to address that:

  1. che admin should be able to specify default idling timeout via CheCluster CR
  2. che-theia definition in the plugin regsitry should not specify machine exec idle timeout

@l0rd
Copy link
Contributor

l0rd commented May 11, 2022

I have created #21390

@che-bot
Copy link
Contributor

che-bot commented Nov 7, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 7, 2022
@che-bot che-bot closed this as completed Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devworkspace-operator area/editor/theia Issues related to the che-theia IDE of Che kind/question Questions that haven't been identified as being feature requests or bugs. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants