Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to double heap size on OOM #718

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

datho7561
Copy link
Contributor

Copied from vscode-java.

Closes #700

Signed-off-by: David Thompson [email protected]

@datho7561 datho7561 marked this pull request as ready for review June 8, 2022 19:55
@datho7561
Copy link
Contributor Author

I've tried testing the case where the user sets the vmargs to " ", so that no -Xmx is set within them. From what I can tell, this means that the Java VM takes 1/4 of the available physical memory as the Xmx. I am having trouble getting lemminx to crash under this circumstance, since most of my computers have decently large amounts of physical memory, and VS Code is not good at opening large files (It crashes and freezes before lemminx does). I'll try again in a memory constrained VM.

@datho7561
Copy link
Contributor Author

Even on a memory constrained VM, I couldn't get the OOM message to appear when using empty jvm args.

@datho7561 datho7561 force-pushed the 700-double-heap-button branch from b18d051 to f0cde93 Compare June 10, 2022 16:04
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so the subscription of the JDK Config changes happens before the LS starts interacting with the file.

Change looks good to me. Feel free to merge.

Copied from vscode-java.

Closes redhat-developer#700

Signed-off-by: David Thompson <[email protected]>
@datho7561 datho7561 force-pushed the 700-double-heap-button branch from f0cde93 to d4828df Compare June 10, 2022 17:41
@datho7561 datho7561 added this to the 0.21.0 milestone Jun 10, 2022
@datho7561 datho7561 merged commit 7f6bca5 into redhat-developer:master Jun 10, 2022
@datho7561 datho7561 deleted the 700-double-heap-button branch June 10, 2022 18:31
@angelozerr angelozerr added the enhancement New feature or request label Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to increase heap maximum in OOM notification
3 participants