Add option to increase heap maximum in OOM notification

[inikishev]

I need to give the thing more memory.
It says "go to xml.server.vmargs and add -Xmx1G.
I search for xml.server.vmargs in settings and press Edit in settings.json

thats what the file looks like

where do i put the " -Xmx1G."

[angelozerr]

Are you in untrusted workspace?

Have you tried to write the settings at hand?

[inikishev]

Are you in untrusted workspace?

Have you tried to write the settings at hand?

sorry I am not sure what that means, how do I know if I am in untrusted workspace and how do I try to to write the settings at hand? I sometimes notice there is a blue notification saying something about untrusted workspace, but it doesn't appear when I try to edit this setting.

[angelozerr]

I suggest that you read https://code.visualstudio.com/blogs/2021/07/06/workspace-trust

[inikishev]

I suggest that you read https://code.visualstudio.com/blogs/2021/07/06/workspace-trust

i disabled the trust in accordance to the article and nothing changed, I still don't know where to put -Xmx1G.

[fbricon]

simply type "xml.server.vmargs" in the User settings.json file

[inikishev]

simply type "xml.server.vmargs" in the User settings.json file

It doesn't like it no matter how i put it

[fbricon]

looks like vscode-xml is not installed/active on your machine

[fbricon]

Ctrl+Space after xml.server.vmargs.
Eventually it should look like "xml.server.vmargs":"-Xmx1G", once you configure it

[inikishev]

looks like vscode-xml is not installed/active on your machine

it definitely is intalled because i am currently using it

[inikishev]

Ctrl+Space after xml.server.vmargs. Eventually it should look like "xml.server.vmargs":"-Xmx1G", once you configure it

where do i put it in the file?

[fbricon]

towards the end of the settings.json file for instance, before the closing bracket.

[angelozerr]

If you go to your second line of your settings.json and you type xml, you should see:

if you continue to type xml.ser, you should see:

[angelozerr]

i disabled the trust in accordance to the article and nothing changed, I still don't know where to put -Xmx1G.

Your workspace should be in trust mode.

@fbricon @rgrunber to avoid this problem, I think the popup which display the out of memory problem should provide a new button Apply suggestion to update the setting xml.server.vmargs with the proper value. What do you think about that?

[rgrunber]

We seem to do that in vscode-java. redhat-developer/vscode-java#2085 . One of the options is "Configure" which appears to double the given XmX value. We should do the same.

https://github.com/redhat-developer/vscode-java/blob/master/src/extension.ts#L87