Document undocumented settings #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datho7561
force-pushed
the
328-undocumented-settings
branch
5 times, most recently
from
5ed0bc1 to
33ac585
Compare
angelozerr
reviewed
Sep 28, 2020
angelozerr
reviewed
Sep 28, 2020
angelozerr
reviewed
Sep 28, 2020
datho7561
force-pushed
the
328-undocumented-settings
branch
2 times, most recently
from
3121949 to
178e95a
Compare
angelozerr
reviewed
Sep 28, 2020
angelozerr
reviewed
Sep 28, 2020
angelozerr
reviewed
Sep 28, 2020
datho7561
force-pushed
the
328-undocumented-settings
branch
4 times, most recently
from
7343276 to
039e1bd
Compare
angelozerr
reviewed
Sep 29, 2020
angelozerr
reviewed
Sep 29, 2020
angelozerr
reviewed
Sep 29, 2020
datho7561
force-pushed
the
328-undocumented-settings
branch
from
039e1bd to
d628440
Compare
|
Still needs some for. For instance, the link from |
|
My replacement strategy assumes that cross page links all have a section. This means |
datho7561
force-pushed
the
328-undocumented-settings
branch
from
70253f7 to
dc48033
Compare
It sounds good, could you add a comment about that please. |
Add new documentation from the wiki. Add links to new documentation in the settings section of `package.json` Links between document pages are replaced during runtime so that they work property with vscode. Closes redhat-developer#328 Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
328-undocumented-settings
branch
from
dc48033 to
dfcb7ec
Compare
angelozerr
approved these changes
Oct 2, 2020
|
Great job @datho7561 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the updates to the wiki into the internal documentation, then adding links from the undocumented settings into the settings.
Closes #328