Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XML documentation for settings which have no documentation #328

Closed
angelozerr opened this issue Sep 16, 2020 · 2 comments · Fixed by #332
Closed

Add XML documentation for settings which have no documentation #328

angelozerr opened this issue Sep 16, 2020 · 2 comments · Fixed by #332
Assignees

Comments

@angelozerr
Copy link
Contributor

Once #326 will be merged, it should be nice to improve documentation by collecting settings (ex : xml.validation.resolveExternalEntities) which are not linked to documentation

@datho7561 datho7561 self-assigned this Sep 17, 2020
@datho7561
Copy link
Contributor

datho7561 commented Sep 17, 2020

Undocumented settings (no link to internal docs) as of commit c90c732. I only included ones that need a longer description.

Using this to keep track of progress documenting the settings as well.
Updating the wiki with the changes first, then adding a link here. Once the documentation is in my internal documentation PR draft, I will check off the item.

@angelozerr
Copy link
Contributor Author

For XML code lens,

datho7561 added a commit to datho7561/vscode-xml that referenced this issue Sep 24, 2020
Add new documentation from the wiki.
Add links to new documentation in the settings section of `package.json`

Closes redhat-developer#328

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Sep 24, 2020
Add new documentation from the wiki.
Add links to new documentation in the settings section of `package.json`

Closes redhat-developer#328

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Sep 24, 2020
Add new documentation from the wiki.
Add links to new documentation in the settings section of `package.json`

Closes redhat-developer#328

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Sep 24, 2020
Add new documentation from the wiki.
Add links to new documentation in the settings section of `package.json`

Closes redhat-developer#328

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Sep 24, 2020
Add new documentation from the wiki.
Add links to new documentation in the settings section of `package.json`

Closes redhat-developer#328

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Sep 28, 2020
Add new documentation from the wiki.
Add links to new documentation in the settings section of `package.json`

Closes redhat-developer#328

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Sep 28, 2020
Add new documentation from the wiki.
Add links to new documentation in the settings section of `package.json`

Closes redhat-developer#328

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Sep 28, 2020
Add new documentation from the wiki.
Add links to new documentation in the settings section of `package.json`

Closes redhat-developer#328

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Sep 28, 2020
Add new documentation from the wiki.
Add links to new documentation in the settings section of `package.json`

Closes redhat-developer#328

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Sep 28, 2020
Add new documentation from the wiki.
Add links to new documentation in the settings section of `package.json`

Closes redhat-developer#328

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Sep 28, 2020
Add new documentation from the wiki.
Add links to new documentation in the settings section of `package.json`

Closes redhat-developer#328

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Sep 29, 2020
Add new documentation from the wiki.
Add links to new documentation in the settings section of `package.json`

Closes redhat-developer#328

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Oct 1, 2020
Add new documentation from the wiki.
Add links to new documentation in the settings section of `package.json`
Links between document pages are replaced during runtime so that
they work property with vscode.

Closes redhat-developer#328

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Oct 1, 2020
Add new documentation from the wiki.
Add links to new documentation in the settings section of `package.json`
Links between document pages are replaced during runtime so that
they work property with vscode.

Closes redhat-developer#328

Signed-off-by: David Thompson <[email protected]>
angelozerr pushed a commit that referenced this issue Oct 2, 2020
Add new documentation from the wiki.
Add links to new documentation in the settings section of `package.json`
Links between document pages are replaced during runtime so that
they work property with vscode.

Closes #328

Signed-off-by: David Thompson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants