-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xml catalog definition should be built-in #375
Comments
@GitMensch I agree with you since we do that xml.xsd for instance, but it's an issue for LemMinx. Could you create an issue on LemMinx please. I could explain you how to do that if you would be interested to provide a PR. |
Sure, I'm a bit short on time currently but with a helping hand would do that. |
Great! Let's create the issue and I will give you some directives. Please not that you must sign a CLA to contribute to LemMinX which belongs to Eclipse organization. |
Fixes redhat-developer/vscode-xml#375 Signed-off-by: azerr <[email protected]>
Fixes redhat-developer/vscode-xml#375 Signed-off-by: azerr <[email protected]>
Fixes redhat-developer/vscode-xml#375 Signed-off-by: azerr <[email protected]>
@angelozerr Thanks for the fix and that you did the extra work yourself (I found no time in the last days to get to something "new"). |
@GitMensch we have released more recently than july (please see https://marketplace.visualstudio.com/items?itemName=redhat.vscode-xml). |
I was confused by that, too. https://github.com/redhat-developer/vscode-xml/tags shows 0.14. So: the last release is now nearly a month old and the 0.15 milestone is the milestone for the next version. it luckily only contains 3 items (including this one), all closed, so it looks like an update from lemminx and a new release may be in sight, |
No problem @GitMensch! As we plan to do a new release soon (with a new exciting feature with binary support to avoid installing Java runtime and I hope really that it will stop our bad reviews about Java https://marketplace.visualstudio.com/items?itemName=redhat.vscode-xml&ssr=false#review-details (all issues with 1 star = Java requirement)), I would like to fix all easy issues.
I understand that, no problem.
You should have the last vsix at https://download.jboss.org/jbosstools/vscode-xml/staging/?C=M;O=D each time we push something in LemMinx or vscode-xml repository. |
This is related to #361 - when the xml catalog is defined as
<catalog xmlns="urn:oasis:names:tc:entity:xmlns:xml:catalog">
the plugin saysThis may be related to internet access on that machine. Still: can you try to have this working, possibly with an internally shipped version of the schema file for xml catalogs?
The text was updated successfully, but these errors were encountered: