xml catalog definition should be built-in #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR embeds catalog.xsd. It doesn't provide tests because there are some existing tests with XML catalog. To test locally the PR:
<?xml version="1.0"?>
<catalog xmlns="urn:oasis:names:tc:entity:xmlns:xml:catalog">
</catalog>You should benefit with completion, validation etc. |
angelozerr
changed the title
angelozerr
force-pushed
the
embedded-xsd-catalog
branch
from
b00bfb7 to
2360097
Compare
Fixes redhat-developer/vscode-xml#375 Signed-off-by: azerr <[email protected]>
|
It doesn't use the embedded version if a |
Yes it's normal. If you use schemaLocation it means that you want to specify a given XSD. the usecase here is to provide a default XSD for |
datho7561
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xml catalog definition should be built-in
Fixes redhat-developer/vscode-xml#375
Signed-off-by: azerr [email protected]