Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support finally tasks #401

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Support finally tasks #401

merged 1 commit into from
Sep 25, 2020

Conversation

evidolob
Copy link
Collaborator

Fix: #345

Demo:
ezgif com-video-to-gif

Signed-off-by: Yevhen Vydolob <[email protected]>
@evidolob evidolob self-assigned this Sep 21, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #401 into master will increase coverage by 0.18%.
The diff coverage is 97.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
+ Coverage   74.51%   74.70%   +0.18%     
==========================================
  Files          58       58              
  Lines        3834     3854      +20     
  Branches      693      699       +6     
==========================================
+ Hits         2857     2879      +22     
+ Misses        977      975       -2     
Impacted Files Coverage Δ
src/yaml-support/tkn-yaml.ts 89.53% <96.29%> (+0.47%) ⬆️
src/model/pipeline/pipeline-model.ts 80.65% <100.00%> (+1.17%) ⬆️
src/pipeline/pipeline-graph.ts 76.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 004f6d5...e82cde3. Read the comment docs.

@evidolob
Copy link
Collaborator Author

@siamaksade I'm not sure about final task in graph

@evidolob evidolob merged commit 413dd59 into master Sep 25, 2020
@evidolob evidolob deleted the support-finally branch September 25, 2020 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for "finally" tasks
2 participants