Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for "finally" tasks #345

Closed
siamaksade opened this issue Jul 9, 2020 · 0 comments · Fixed by #401
Closed

Support for "finally" tasks #345

siamaksade opened this issue Jul 9, 2020 · 0 comments · Fixed by #401
Assignees
@evidolob
Labels
enhancement New feature or request
Milestone
Sprint #190

Comments

@siamaksade
Copy link

Pipelines added support for a list of "final" tasks starting from Tekton 0.14:
https://github.com/tektoncd/pipeline/blob/master/docs/pipelines.md#adding-finally-to-the-pipeline

This format should be supported in the editor and also added to the pipeline and pipelinerun diagrams
@siamaksade siamaksade added the enhancement New feature or request label Jul 9, 2020
@siamaksade siamaksade changed the title Support for "final" tasks Support for "finally" tasks Jul 30, 2020
@siamaksade siamaksade added this to the Sprint #188 milestone Jul 30, 2020
@evidolob evidolob mentioned this issue Aug 20, 2020
Merged
@sudhirverma sudhirverma modified the milestones: Sprint #188, Sprint #189 Aug 20, 2020
@sudhirverma sudhirverma self-assigned this Aug 20, 2020
@evidolob evidolob assigned evidolob and unassigned sudhirverma Sep 10, 2020
@evidolob evidolob modified the milestones: Sprint #189, Sprint #190 Sep 16, 2020
evidolob added a commit that referenced this issue Sep 21, 2020
@evidolob
#345 support finally tasks
e82cde3 
Signed-off-by: Yevhen Vydolob <[email protected]>
@evidolob evidolob mentioned this issue Sep 21, 2020
Merged
evidolob added a commit that referenced this issue Sep 25, 2020
@evidolob
#345 support finally tasks
413dd59 
Signed-off-by: Yevhen Vydolob <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evidolob evidolob

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint #190
Development

Successfully merging a pull request may close this issue.

Support finally tasks redhat-developer/vscode-tekton
3 participants
@evidolob @siamaksade @sudhirverma