-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable generate hashCode and equals source action #814
Enable generate hashCode and equals source action #814
Conversation
Peer PR on eclipse.jdt.ls side eclipse-jdtls/eclipse.jdt.ls#940 |
Signed-off-by: Jinbo Wang <[email protected]>
9a4be22
to
82c041e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of remarks so far (we can get rid of one prompt and improve the dialog - I like clear actionable choices ), but that's a promising start. I still need to get my head around the API though.
Signed-off-by: Jinbo Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should expose at least one more option, to use instance of
to perform comparisons.
So I'd change the preferences to have:
- "java.codeGeneration.hashcodeEquals.useJava7Objects".
- "java.codeGeneration.hashcodeEquals.compareInstanceOf"
Eventually, we might as well expose generateComments and useBrackets
…ettings Signed-off-by: Jinbo Wang <[email protected]>
…action Signed-off-by: Jinbo Wang <[email protected]>
Here are the new preferences controlling the code generation:
|
Signed-off-by: Jinbo Wang [email protected]
Feature #597.
Prompt to select fields to include:
