Generate hashCode and equals with prompt #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you please add unit tests? |
|
sure, i'm doing that. |
testforstephen
force-pushed
the
jinbo_hashcodeequals
branch
from
7170abe to
b8082c8
Compare
testforstephen
changed the title
Signed-off-by: Jinbo Wang <[email protected]>
testforstephen
force-pushed
the
jinbo_hashcodeequals
branch
from
b8082c8 to
314cb67
Compare
fbricon
reviewed
Mar 2, 2019
...eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/HashCodeEqualsHandler.java
Outdated
Show resolved
Hide resolved
fbricon
reviewed
Mar 2, 2019
...eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/HashCodeEqualsHandler.java
Outdated
Show resolved
Hide resolved
fbricon
reviewed
Mar 2, 2019
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/preferences/Preferences.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jinbo Wang <[email protected]>
fbricon
reviewed
Mar 6, 2019
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/preferences/Preferences.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jinbo Wang <[email protected]>
|
Damn, we're now 60 LOC over the threshold requiring submitting a CQ. |
fbricon
reviewed
Mar 7, 2019
....jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/text/correction/SourceAssistProcessor.java
Outdated
Show resolved
Hide resolved
fbricon
reviewed
Mar 7, 2019
....jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/text/correction/SourceAssistProcessor.java
Show resolved
Hide resolved
Signed-off-by: Jinbo Wang <[email protected]>
|
test this please |
|
Thanks @testforstephen ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang [email protected]
Close #168
vscode client implementation: redhat-developer/vscode-java#814
Prompt to select fields to include:
