Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rbac): update e2e test for bug fix #1090

Merged
merged 1 commit into from
Apr 8, 2024
Merged

chore(rbac): update e2e test for bug fix #1090

merged 1 commit into from
Apr 8, 2024

Conversation

ciiay
Copy link
Contributor

@ciiay ciiay commented Mar 19, 2024 •
edited
Loading

Description

Added a text verification for rbac RoleList page after updated a role. This is for RHIDP-1362.
Also fixed a bug of e2e tests checkAndReauthorizeGithubApp function.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related
pr_1090_e2e_test

@ciiay ciiay requested a review from a team as a code owner March 19, 2024 22:13
@openshift-ci openshift-ci bot requested review from josephca and rnapoles-rh March 19, 2024 22:13
@ciiay ciiay mentioned this pull request Mar 19, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1090!

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1090!

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1090!

@ciiay ciiay force-pushed the rhidp-1362-update-e2e-test-for-bug-fix branch from cc7b3eb to e4487b6 Compare March 21, 2024 17:43
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1090!

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1090!

@debsmita1
Copy link
Member

The test case is passing

Screenshot 2024-03-28 at 7 03 24 PM

Thank you @ciiay !!

Please rebase and push again.

@ciiay ciiay force-pushed the rhidp-1362-update-e2e-test-for-bug-fix branch from ce0e093 to 6129e12 Compare April 1, 2024 13:55
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1090!

@ciiay ciiay force-pushed the rhidp-1362-update-e2e-test-for-bug-fix branch 2 times, most recently from cd960bf to 4ea36a1 Compare April 1, 2024 21:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1090!

@subhashkhileri
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 2, 2024
@invincibleJai
Copy link
Contributor

/approve

verified the changes locally, this works as expected

@openshift-ci openshift-ci bot added the approved label Apr 2, 2024
@ciiay ciiay force-pushed the rhidp-1362-update-e2e-test-for-bug-fix branch from 4ea36a1 to b26ac74 Compare April 8, 2024 13:24
@openshift-ci openshift-ci bot removed the lgtm label Apr 8, 2024
@ciiay ciiay force-pushed the rhidp-1362-update-e2e-test-for-bug-fix branch from b26ac74 to 04118e9 Compare April 8, 2024 13:42
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.6% Duplication on New Code

See analysis details on SonarCloud

@invincibleJai
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 8, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, subhashkhileri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1090!

@openshift-merge-bot openshift-merge-bot bot merged commit 2f81641 into redhat-developer:main Apr 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephca josephca Awaiting requested review from josephca

@rnapoles-rh rnapoles-rh Awaiting requested review from rnapoles-rh

@invincibleJai invincibleJai Awaiting requested review from invincibleJai

@debsmita1 debsmita1 Awaiting requested review from debsmita1

@subhashkhileri subhashkhileri Awaiting requested review from subhashkhileri

Assignees

@invincibleJai invincibleJai

@subhashkhileri subhashkhileri

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ciiay @debsmita1 @subhashkhileri @invincibleJai