Skip to content

Commit

Permalink
chore(rbac): update e2e test for bug fix
Browse files Browse the repository at this point in the history
Signed-off-by: Yi Cai <[email protected]>
  • Loading branch information
ciiay committed Apr 1, 2024
1 parent 3b6f477 commit 4ea36a1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions e2e-tests/playwright/e2e/plugins/rbac/rbac.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ test.describe.serial('Test RBAC plugin as an admin user', () => {
await uiHelper.clickButton('Next');
await uiHelper.clickButton('Next');
await uiHelper.clickButton('Save');
await uiHelper.verifyText(
'Role role:default/test-role updated successfully',
);

await page.locator(HomePagePO.searchBar).waitFor({ state: 'visible' });
await page.locator(HomePagePO.searchBar).fill('test-role');
Expand Down
2 changes: 1 addition & 1 deletion e2e-tests/playwright/utils/Common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export class Common {
await this.page.waitForTimeout(1000); // Using page here because if the popup closes automatically, it throws an error during the wait
}

const locator = popup.locator('#js-oauth-authorize-btn');
const locator = popup.locator('button.js-oauth-authorize-btn');
if (!popup.isClosed() && (await locator.isVisible())) {
await popup.locator('body').click();
await locator.waitFor();
Expand Down

0 comments on commit 4ea36a1

Please sign in to comment.