Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default secrets #609

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

gazarenkov
Copy link
Member

Description

Added possibility for default secret to configure:

  • several secrets (like PVCs)
  • per-secret secret's mountPath
  • containers the secret should be mounted to (not only Backstage container)

Which issue(s) does this PR fix or relate to

https://issues.redhat.com/browse/RHIDP-4785

PR acceptance criteria

  • Tests
  • Documentation

Copy link

openshift-ci bot commented Dec 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from gazarenkov. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pkg/model/secretenvs.go Dismissed Show dismissed Hide dismissed
```
In the example above the Secret called **mysecret** will be mounted to **/mount/path/from/annotation** directory

#### rhdh.redhat.com/containers for mounting volume to specific container(s)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems to be built on top of https://github.com/redhat-developer/rhdh-operator/pull/582/files#diff-17ed18489a956f326ec0fe4040850c5bc9261d4631fb42da4c52891d74a59180, right?
In this case, to make it easier to review the diff, I'd suggest marking this as draft (and update it once #582 is merged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants