-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default secrets #609
base: main
Are you sure you want to change the base?
Default secrets #609
Conversation
Signed-off-by: gazarenkov <[email protected]>
Signed-off-by: gazarenkov <[email protected]>
Signed-off-by: gazarenkov <[email protected]>
Signed-off-by: gazarenkov <[email protected]>
Signed-off-by: gazarenkov <[email protected]>
Signed-off-by: gazarenkov <[email protected]>
Signed-off-by: gazarenkov <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
``` | ||
In the example above the Secret called **mysecret** will be mounted to **/mount/path/from/annotation** directory | ||
|
||
#### rhdh.redhat.com/containers for mounting volume to specific container(s) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR seems to be built on top of https://github.com/redhat-developer/rhdh-operator/pull/582/files#diff-17ed18489a956f326ec0fe4040850c5bc9261d4631fb42da4c52891d74a59180, right?
In this case, to make it easier to review the diff, I'd suggest marking this as draft (and update it once #582 is merged).
Description
Added possibility for default secret to configure:
Which issue(s) does this PR fix or relate to
https://issues.redhat.com/browse/RHIDP-4785
PR acceptance criteria